Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: src/handles.cc

Issue 172503002: Handlify JSObject::CanSetCallback. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/isolate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 threw); 530 threw);
531 if (*threw) return content; 531 if (*threw) return content;
532 content = AddKeysFromJSArray(content, Handle<JSArray>::cast(names)); 532 content = AddKeysFromJSArray(content, Handle<JSArray>::cast(names));
533 break; 533 break;
534 } 534 }
535 535
536 Handle<JSObject> current(JSObject::cast(*p), isolate); 536 Handle<JSObject> current(JSObject::cast(*p), isolate);
537 537
538 // Check access rights if required. 538 // Check access rights if required.
539 if (current->IsAccessCheckNeeded() && 539 if (current->IsAccessCheckNeeded() &&
540 !isolate->MayNamedAccess(*current, 540 !isolate->MayNamedAccessWrapper(current,
541 isolate->heap()->undefined_value(), 541 isolate->factory()->undefined_value(),
542 v8::ACCESS_KEYS)) { 542 v8::ACCESS_KEYS)) {
543 isolate->ReportFailedAccessCheck(*current, v8::ACCESS_KEYS); 543 isolate->ReportFailedAccessCheckWrapper(current, v8::ACCESS_KEYS);
544 if (isolate->has_scheduled_exception()) { 544 if (isolate->has_scheduled_exception()) {
545 isolate->PromoteScheduledException(); 545 isolate->PromoteScheduledException();
546 *threw = true; 546 *threw = true;
547 } 547 }
548 break; 548 break;
549 } 549 }
550 550
551 // Compute the element keys. 551 // Compute the element keys.
552 Handle<FixedArray> element_keys = 552 Handle<FixedArray> element_keys =
553 isolate->factory()->NewFixedArray(current->NumberOfEnumElements()); 553 isolate->factory()->NewFixedArray(current->NumberOfEnumElements());
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
790 Handle<Code> code) { 790 Handle<Code> code) {
791 heap->EnsureWeakObjectToCodeTable(); 791 heap->EnsureWeakObjectToCodeTable();
792 Handle<DependentCode> dep(heap->LookupWeakObjectToCodeDependency(*object)); 792 Handle<DependentCode> dep(heap->LookupWeakObjectToCodeDependency(*object));
793 dep = DependentCode::Insert(dep, DependentCode::kWeaklyEmbeddedGroup, code); 793 dep = DependentCode::Insert(dep, DependentCode::kWeaklyEmbeddedGroup, code);
794 CALL_HEAP_FUNCTION_VOID(heap->isolate(), 794 CALL_HEAP_FUNCTION_VOID(heap->isolate(),
795 heap->AddWeakObjectToCodeDependency(*object, *dep)); 795 heap->AddWeakObjectToCodeDependency(*object, *dep));
796 } 796 }
797 797
798 798
799 } } // namespace v8::internal 799 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698