Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 172503002: Handlify JSObject::CanSetCallback. (Closed)

Created:
6 years, 10 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Handlify JSObject::CanSetCallback. Also use temporary wrapper functions where possible to mark progress. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -67 lines) Patch
M src/handles.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/isolate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 20 chunks +46 lines, -42 lines 0 comments Download
M src/runtime.cc View 8 chunks +24 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 10 months ago (2014-02-19 15:36:26 UTC) #1
Igor Sheludko
lgtm
6 years, 10 months ago (2014-02-24 11:42:08 UTC) #2
Yang
6 years, 9 months ago (2014-03-10 08:29:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19743 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698