Issue 1725006: Changes the tab menu to use pin and unpin instead of a check. The mac

Issue 1725006: Changes the tab menu to use pin and unpin instead of a check. The mac (Closed)

Created:
10 years, 8 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), James Hawkins, Ben Goodger (Google)

CC:
chromium-reviews

Visibility:
Public.

Description

Changes the tab menu to use pin and unpin instead of a check. The mac changes to use the right thing (pinned vs mini) will be done separately. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45581

Patch Set 1 #

Total comments: 2

Patch Set 2 : Integrated review feedback #

Patch Set 3 : Merged with tip of tree and updated unit tests #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -58 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 2	2 chunks	+6 lines, -9 lines	0 comments	Download
M	chrome/browser/cocoa/tab_controller.mm	View	1	3 chunks	+5 lines, -16 lines	0 comments	Download
M	chrome/browser/gtk/tabs/tab_gtk.cc	View	1	4 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/tab_menu_model.h	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_menu_model.cc	View		1 chunk	+7 lines, -13 lines	0 comments	Download
M	chrome/browser/tab_menu_model_unittest.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/views/tabs/tab.cc	View		3 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

http://codereview.chromium.org/1725006/diff/1/6 File chrome/browser/tab_menu_model.h (right): http://codereview.chromium.org/1725006/diff/1/6#newcode14 chrome/browser/tab_menu_model.h:14: // tab (should as the pinned state). To make ...

10 years, 8 months ago (2010-04-22 18:34:47 UTC) #3

pink (ping after 24hrs)

http://codereview.chromium.org/1725006/diff/1/3 File chrome/browser/cocoa/tab_controller.mm (right): http://codereview.chromium.org/1725006/diff/1/3#newcode128 chrome/browser/cocoa/tab_controller.mm:128: // TODO: this is wrong, it should use pinned, ...

10 years, 8 months ago (2010-04-22 18:57:35 UTC) #4

Added bug # and updated comment.

Expand Messages | Collapse Messages