Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 17250006: Move static flag modifications to V8::InitializeOncePerProcessImpl(). (Closed)

Created:
7 years, 6 months ago by Hannes Payer (out of office)
Modified:
7 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Move static flag modifications to V8::InitializeOncePerProcessImpl(). BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15198

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -27 lines) Patch
M src/isolate.cc View 1 chunk +1 line, -27 lines 0 comments Download
M src/v8.cc View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
7 years, 6 months ago (2013-06-17 15:10:35 UTC) #1
Michael Starzinger
https://codereview.chromium.org/17250006/diff/1/src/v8.cc File src/v8.cc (right): https://codereview.chromium.org/17250006/diff/1/src/v8.cc#newcode274 src/v8.cc:274: if (FLAG_sweeper_threads == 0) { This should actually say ...
7 years, 6 months ago (2013-06-17 15:17:25 UTC) #2
Hannes Payer (out of office)
Now the flag definition is stricter than before, i.e., the actual enabling flags are more ...
7 years, 6 months ago (2013-06-17 17:07:30 UTC) #3
Michael Starzinger
LGTM.
7 years, 6 months ago (2013-06-17 17:12:52 UTC) #4
Hannes Payer (out of office)
7 years, 6 months ago (2013-06-19 08:57:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r15198 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698