Issue 1724853002: Add wrap/unwrap_jso calls in native_DOMImplementation, remove unused _DOMStringMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1724853002: Add wrap/unwrap_jso calls in native_DOMImplementation, remove unused _DOMStringMap (Closed)

Created:
4 years, 10 months ago by Alan Knight

Modified:
4 years, 10 months ago

Reviewers:
terry, Jacob

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add wrap/unwrap_jso calls in native_DOMImplementation, remove unused _DOMStringMap BUG= Committed: https://github.com/dart-lang/sdk/commit/14b2dfd8dd89ac28aa1866209149c3878fe6a988

Patch Set 1 #

Total comments: 1

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -36 lines)			Patch
	M	tools/dom/src/native_DOMImplementation.dart	View		5 chunks	+16 lines, -36 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Alan Knight

Committed patchset #1 (id:1) manually as 14b2dfd8dd89ac28aa1866209149c3878fe6a988 (presubmit successful).

4 years, 10 months ago (2016-02-23 19:21:08 UTC) #4

terry

4 years, 10 months ago (2016-02-23 19:28:01 UTC) #5

Message was sent while issue was closed.

lgtm just 1 minor nit

https://codereview.chromium.org/1724853002/diff/1/tools/dom/src/native_DOMImp...
File tools/dom/src/native_DOMImplementation.dart (right):

https://codereview.chromium.org/1724853002/diff/1/tools/dom/src/native_DOMImp...
tools/dom/src/native_DOMImplementation.dart:830: bool get closed =>
wrap_jso(_blink.Blink_DOMWindowCrossFrame.get_closed(unwrap_jso(this)));
wrap_jso on a bool isn't necessary.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages