src/a64/codegen-a64.h - Issue 172483002: A64: Fix int32 use in Lithium string functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/a64/codegen-a64.h

Issue 172483002: A64: Fix int32 use in Lithium string functions (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix typo in assertion. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/a64/codegen-a64.h

diff --git a/src/a64/codegen-a64.h b/src/a64/codegen-a64.h

index d66bd34a93665de8e5196047c929efa3d1576626..1bb9661f0b4b70d9e35d3a7f73186898063ac0c3 100644

--- a/src/a64/codegen-a64.h

+++ b/src/a64/codegen-a64.h

@@ -38,7 +38,8 @@ class StringCharLoadGenerator : public AllStatic {

public:

// Generates the code for handling different string types and loading the

// indexed character into |result|. We expect |index| as untagged input and

- // |result| as untagged output.

+ // |result| as untagged output. Register index is asserted to be a 32-bit W

+ // register.

static void Generate(MacroAssembler* masm,

« no previous file with comments | « src/a64/code-stubs-a64.cc ('k') | src/a64/codegen-a64.cc » ('j') | no next file with comments »