Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Side by Side Diff: src/a64/code-stubs-a64.cc

Issue 172483002: A64: Fix int32 use in Lithium string functions (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix typo in assertion. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/a64/codegen-a64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3522 matching lines...) Expand 10 before | Expand all | Expand 10 after
3533 __ Bind(&got_smi_index_); 3533 __ Bind(&got_smi_index_);
3534 // Check for index out of range. 3534 // Check for index out of range.
3535 __ Ldrsw(result_, UntagSmiFieldMemOperand(object_, String::kLengthOffset)); 3535 __ Ldrsw(result_, UntagSmiFieldMemOperand(object_, String::kLengthOffset));
3536 __ Cmp(result_, Operand::UntagSmi(index_)); 3536 __ Cmp(result_, Operand::UntagSmi(index_));
3537 __ B(ls, index_out_of_range_); 3537 __ B(ls, index_out_of_range_);
3538 3538
3539 __ SmiUntag(index_); 3539 __ SmiUntag(index_);
3540 3540
3541 StringCharLoadGenerator::Generate(masm, 3541 StringCharLoadGenerator::Generate(masm,
3542 object_, 3542 object_,
3543 index_, 3543 index_.W(),
3544 result_, 3544 result_,
3545 &call_runtime_); 3545 &call_runtime_);
3546 __ SmiTag(result_); 3546 __ SmiTag(result_);
3547 __ Bind(&exit_); 3547 __ Bind(&exit_);
3548 } 3548 }
3549 3549
3550 3550
3551 void StringCharCodeAtGenerator::GenerateSlow( 3551 void StringCharCodeAtGenerator::GenerateSlow(
3552 MacroAssembler* masm, 3552 MacroAssembler* masm,
3553 const RuntimeCallHelper& call_helper) { 3553 const RuntimeCallHelper& call_helper) {
(...skipping 2245 matching lines...) Expand 10 before | Expand all | Expand 10 after
5799 MemOperand(fp, 6 * kPointerSize), 5799 MemOperand(fp, 6 * kPointerSize),
5800 NULL); 5800 NULL);
5801 } 5801 }
5802 5802
5803 5803
5804 #undef __ 5804 #undef __
5805 5805
5806 } } // namespace v8::internal 5806 } } // namespace v8::internal
5807 5807
5808 #endif // V8_TARGET_ARCH_A64 5808 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « no previous file | src/a64/codegen-a64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698