Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1724793002: Remove _FDE_BLOCK_BUFFER as it's always defined. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove _FDE_BLOCK_BUFFER as it's always defined. This CL cleans up the code enabled and disabled by _FDE_BLOCK_BUFFER. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2eaa2ef03f7fc9417007d554ee955137fe9ff7b4

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -581 lines) Patch
M xfa/src/fdp/src/xml/fde_xml_imp.h View 7 chunks +4 lines, -31 lines 0 comments Download
M xfa/src/fdp/src/xml/fde_xml_imp.cpp View 7 chunks +8 lines, -550 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL.
4 years, 10 months ago (2016-02-23 16:10:50 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1724793002/diff/1/xfa/src/fdp/src/xml/fde_xml_imp.cpp File xfa/src/fdp/src/xml/fde_xml_imp.cpp (right): https://codereview.chromium.org/1724793002/diff/1/xfa/src/fdp/src/xml/fde_xml_imp.cpp#newcode19 xfa/src/fdp/src/xml/fde_xml_imp.cpp:19: FX_BOOL FDE_IsXMLValidChar(FX_WCHAR ch) { nit: bsearching a 5-element ...
4 years, 10 months ago (2016-02-23 17:14:30 UTC) #3
dsinclair
4 years, 10 months ago (2016-02-23 17:42:47 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2eaa2ef03f7fc9417007d554ee955137fe9ff7b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698