[fullcodegen] Implement control flow across do-expressions.

[fullcodegen] Implement control flow across do-expressions.

This implements proper handling of local control flow (i.e. break and
continue) that spans the boundary of a do-expression. We can no longer
determine the number of operands to be dropped from the nesting of
statements alone, instead we use the new precise operand stack depth
tracking.

R=jarin@chromium.org
TEST=mjsunit/harmony/do-expressions-control
BUG=v8:4488
LOG=n

Committed: https://crrev.com/ee8108b71c7e63392ba9814d859aa06f47acf5e5
Cr-Commit-Position: refs/heads/master@{#34246}

[Michael Starzinger, 2016-02-23 14:01:25]

mstarzinger@chromium.org changed reviewers:
+ adamk@chromium.org, rossberg@chromium.org

[Michael Starzinger, 2016-02-23 14:01:26]

Ports are still missing, but I wanted to get a first round of comments
beforehand.

Jaro: PTAL.
Adam/Andreas: FYI.

https://codereview.chromium.org/1724753002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/1724753002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:640: DEFINE_BOOL(verify_operand_stack_depth, true,
Note that this is only turned on for full try-bot coverage. Will turn it off
again before I land. I will investigate whether this can be enabled by default
(in debug mode) as part of a separate CL.

[Michael Starzinger, 2016-02-23 14:02:25]

Description was changed from

==========
[fullcodegen] Implement control flow accross do-expressions.

This implements proper handling of local control flow (i.e. break and
continue) that spans the boundary of a do-expression. We can no longer
determine the number of operands to be dropped from the nesting of
statements alone, instead we use the new precise operand stack depth
tracking.

R=jarin@chromium.org
TEST=mjsunit/harmony/do-expressions-control
BUG=v8:4488
LOG=n
==========

to

==========
[fullcodegen] Implement control flow across do-expressions.

This implements proper handling of local control flow (i.e. break and
continue) that spans the boundary of a do-expression. We can no longer
determine the number of operands to be dropped from the nesting of
statements alone, instead we use the new precise operand stack depth
tracking.

R=jarin@chromium.org
TEST=mjsunit/harmony/do-expressions-control
BUG=v8:4488
LOG=n
==========

[rossberg, 2016-02-23 14:38:33]

https://codereview.chromium.org/1724753002/diff/1/test/mjsunit/harmony/do-exp...
File test/mjsunit/harmony/do-expressions-control.js (right):

https://codereview.chromium.org/1724753002/diff/1/test/mjsunit/harmony/do-exp...
test/mjsunit/harmony/do-expressions-control.js:7: (function TestDoForInDoBreak()
{
Might be worth also having tests with labeled break/continue.

[Michael Starzinger, 2016-02-23 15:52:40]

Ports done. Comments addressed.

https://codereview.chromium.org/1724753002/diff/1/test/mjsunit/harmony/do-exp...
File test/mjsunit/harmony/do-expressions-control.js (right):

https://codereview.chromium.org/1724753002/diff/1/test/mjsunit/harmony/do-exp...
test/mjsunit/harmony/do-expressions-control.js:7: (function TestDoForInDoBreak()
{
On 2016/02/23 14:38:33, rossberg wrote:
> Might be worth also having tests with labeled break/continue. 

Done.

[rossberg, 2016-02-23 16:04:32]

Test LGTM, referring to others for compiler changes.

https://codereview.chromium.org/1724753002/diff/1/test/mjsunit/harmony/do-exp...
File test/mjsunit/harmony/do-expressions-control.js (right):

https://codereview.chromium.org/1724753002/diff/1/test/mjsunit/harmony/do-exp...
test/mjsunit/harmony/do-expressions-control.js:7: (function TestDoForInDoBreak()
{
On 2016/02/23 15:52:40, Michael Starzinger wrote:
> On 2016/02/23 14:38:33, rossberg wrote:
> > Might be worth also having tests with labeled break/continue. 
> 
> Done.

Awesome, thanks!

[Michael Starzinger, 2016-02-23 16:33:27]

This is ready for a final review.

[Benedikt Meurer, 2016-02-24 08:57:10]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-02-24 08:57:10]

Nice cleanup. LGTM. Love the tests :-)

[Jarin, 2016-02-24 09:55:10]

Very nice. LGTM!

I hope we can clean up NestedStatement::Exit even more in future. 

The only funny Exit is in TryFinally, but that one is only called in the special
branch of emit/continue/return, so there is no need for it to be virtual.

[Michael Starzinger, 2016-02-24 11:02:37]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-02-24 11:02:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org, bmeurer@chromium.org, jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1724753002/#ps100001
(title: "Disable verification.")

[commit-bot: I haz the power, 2016-02-24 11:02:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1724753002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1724753002/100001

[commit-bot: I haz the power, 2016-02-24 11:05:16]

Description was changed from

==========
[fullcodegen] Implement control flow across do-expressions.

This implements proper handling of local control flow (i.e. break and
continue) that spans the boundary of a do-expression. We can no longer
determine the number of operands to be dropped from the nesting of
statements alone, instead we use the new precise operand stack depth
tracking.

R=jarin@chromium.org
TEST=mjsunit/harmony/do-expressions-control
BUG=v8:4488
LOG=n
==========

to

==========
[fullcodegen] Implement control flow across do-expressions.

This implements proper handling of local control flow (i.e. break and
continue) that spans the boundary of a do-expression. We can no longer
determine the number of operands to be dropped from the nesting of
statements alone, instead we use the new precise operand stack depth
tracking.

R=jarin@chromium.org
TEST=mjsunit/harmony/do-expressions-control
BUG=v8:4488
LOG=n
==========

[commit-bot: I haz the power, 2016-02-24 11:05:17]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-24 11:06:15]

Description was changed from

==========
[fullcodegen] Implement control flow across do-expressions.

This implements proper handling of local control flow (i.e. break and
continue) that spans the boundary of a do-expression. We can no longer
determine the number of operands to be dropped from the nesting of
statements alone, instead we use the new precise operand stack depth
tracking.

R=jarin@chromium.org
TEST=mjsunit/harmony/do-expressions-control
BUG=v8:4488
LOG=n
==========

to

==========
[fullcodegen] Implement control flow across do-expressions.

This implements proper handling of local control flow (i.e. break and
continue) that spans the boundary of a do-expression. We can no longer
determine the number of operands to be dropped from the nesting of
statements alone, instead we use the new precise operand stack depth
tracking.

R=jarin@chromium.org
TEST=mjsunit/harmony/do-expressions-control
BUG=v8:4488
LOG=n

Committed: https://crrev.com/ee8108b71c7e63392ba9814d859aa06f47acf5e5
Cr-Commit-Position: refs/heads/master@{#34246}
==========

[commit-bot: I haz the power, 2016-02-24 11:06:16]

Patchset 6 (id:??) landed as
https://crrev.com/ee8108b71c7e63392ba9814d859aa06f47acf5e5
Cr-Commit-Position: refs/heads/master@{#34246}