Fix QUIC alternate protocol behavior so that that main job does not wait

net/quic/quic_client_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_client_session.h"
 
 #include "base/callback_helpers.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/stl_util.h"
@@ skipping 52 matching lines @@
           new QuicCryptoClientStream(server_hostname, this, crypto_config));
 
   connection->set_debug_visitor(&logger_);
   // TODO(rch): pass in full host port proxy pair
   net_log_.BeginEvent(
       NetLog::TYPE_QUIC_SESSION,
       NetLog::StringCallback("host", &server_hostname));
 }
 
 QuicClientSession::~QuicClientSession() {
-  DCHECK(callback_.is_null());

[willchan no longer on Chromium, 2013/06/21 23:55:45]

Why did this change?

[Ryan Hamilton, 2013/06/22 00:00:36]

Ah, right.  This was a check that raman added when we ported the code to
Chromium.  At the time, we though that this check was a good sanity check
because it should never happen that we are destroyed while we are connecting. 
However, this turns out not to be correct.  If we shutdown during a connection,
we hit this.  In the new test I added, that's exactly what happens.  The
QuicClientSession is still connecting (and hence the callback is set) when the
stack shuts down.

[willchan no longer on Chromium, 2013/06/22 00:14:33]

Great, sounds good.

   connection()->set_debug_visitor(NULL);
   net_log_.EndEvent(NetLog::TYPE_QUIC_SESSION);
 
   if (IsEncryptionEstablished())
     RecordHandshakeState(STATE_ENCRYPTION_ESTABLISHED);
   if (IsCryptoHandshakeConfirmed())
     RecordHandshakeState(STATE_HANDSHAKE_CONFIRMED);
   else
     RecordHandshakeState(STATE_FAILED);
 
@@ skipping 149 matching lines @@
   // use a weak pointer to be safe.
   connection()->ProcessUdpPacket(local_address, peer_address, packet);
   if (!connection()->connected()) {
     stream_factory_->OnSessionClose(this);
     return;
   }
   StartReading();
 }
 
 }  // namespace net