TCPSocket/UDPSocket: don't update internal state or access user buffers after Close().

TCPSocket/UDPSocket: don't update internal state or access user buffers after Close().

The CL also removes some NOTREACHED()s which could be reached in normal (but rare) cases.

BUG=247225
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208029

[yzshen1, 2013-06-21 23:16:54]

Hi, David.

Would you please take a look? Thanks!

[dmichael (off chromium), 2013-06-22 01:19:16]

Nice catch, lgtm

https://codereview.chromium.org/17247004/diff/1/ppapi/shared_impl/tcp_socket_...
File ppapi/shared_impl/tcp_socket_shared.cc (right):

https://codereview.chromium.org/17247004/diff/1/ppapi/shared_impl/tcp_socket_...
ppapi/shared_impl/tcp_socket_shared.cc:50: // abort |connect_cllback_|. We don't
want to udpate |connection_state_| or
nit: cllback->callback, udpate->update

[commit-bot: I haz the power, 2013-06-22 04:58:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/17247004/5003

[yzshen1, 2013-06-22 04:58:19]

Thanks, David!

https://codereview.chromium.org/17247004/diff/1/ppapi/shared_impl/tcp_socket_...
File ppapi/shared_impl/tcp_socket_shared.cc (right):

https://codereview.chromium.org/17247004/diff/1/ppapi/shared_impl/tcp_socket_...
ppapi/shared_impl/tcp_socket_shared.cc:50: // abort |connect_cllback_|. We don't
want to udpate |connection_state_| or
Done. Thanks!
On 2013/06/22 01:19:16, dmichael wrote:
> nit: cllback->callback, udpate->update

[commit-bot: I haz the power, 2013-06-22 05:16:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/17247004/5003

[commit-bot: I haz the power, 2013-06-22 05:38:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/17247004/5003

[commit-bot: I haz the power, 2013-06-22 05:40:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/17247004/5003

[commit-bot: I haz the power, 2013-06-22 14:08:07]

Change committed as 208029