src/IceInstX86BaseImpl.h - Issue 1724643002: Subzero: Basic unconditional branch for Mips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX86BaseImpl.h

Issue 1724643002: Subzero: Basic unconditional branch for Mips. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: changes suggested by stichnot Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstX86BaseImpl.h

diff --git a/src/IceInstX86BaseImpl.h b/src/IceInstX86BaseImpl.h

index b80a169e2096072ac92c56141e24af1aab55279c..64d235e6e57211e900396a7f999a50db10643e1f 100644

--- a/src/IceInstX86BaseImpl.h

+++ b/src/IceInstX86BaseImpl.h

@@ -98,6 +98,8 @@ InstImpl<TraitsType>::InstX86Label::InstX86Label(Cfg *Func,

template <typename TraitsType>

IceString InstImpl<TraitsType>::InstX86Label::getName(const Cfg *Func) const {

+ if (!BuildDefs::dump())

+ return IceString();

return ".L" + Func->getFunctionName() + "$local$__" + std::to_string(Number);

}

« no previous file with comments | « src/IceInstMIPS32.cpp ('k') | src/IceTargetLoweringMIPS32.h » ('j') | tests_lit/llvm2ice_tests/uncond_br.ll » ('J')