tests_lit/llvm2ice_tests/uncond_br.ll - Issue 1724643002: Subzero: Basic unconditional branch for Mips.

Side by Side Diff: tests_lit/llvm2ice_tests/uncond_br.ll

Issue 1724643002: Subzero: Basic unconditional branch for Mips. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 ; TODO(rkotler): Stop skipping unimplemented parts (via --skip-unimplemented)

	2 ; once enough infrastructure is in. Also, switch to --filetype=obj

	3 ; when possible.

	4 ; RUN: %if --need=target_MIPS32 --need=allow_dump \

	5 ; RUN: --command %p2i --filetype=asm --assemble \

	6 ; RUN: --disassemble --target mips32 -i %s --args -O2 --skip-unimplemented \

	7 ; RUN: -allow-externally-defined-symbols \

	8 ; RUN: \| %if --need=target_MIPS32 --need=allow_dump \

	9 ; RUN: --command FileCheck --check-prefix MIPS32 %s

	10

	11 define internal void @uncond1(i32 %i) {

	12 %1 = alloca i8, i32 4, align 4

	13 %.bc = bitcast i8* %1 to i32*

	14 store i32 %i, i32* %.bc, align 1

	15 br label %2

	16 ; <label>:2 ; preds = %2, %0
	Jim Stichnoth 2016/02/23 06:18:51 I know this was basically auto-generated, but it w I know this was basically auto-generated, but it would be more readable and probably more reliable if you give this label an actual name, like: ... br label %target target: ... rkotlerimgtec 2016/02/23 23:17:20 Done. Show quoted text On 2016/02/23 06:18:51, stichnot wrote: > I know this was basically auto-generated, but it would be more readable and > probably more reliable if you give this label an actual name, like: > > ... > br label %target > target: > ... Done.
	17 %.bc1 = bitcast i8* %1 to i32*

	18 %3 = load i32, i32* %.bc1, align 1

	19 %4 = add i32 %3, 1

	20 %.bc2 = bitcast i8* %1 to i32*

	21 store i32 %4, i32* %.bc2, align 1

	22 br label %2

	23 }

	24

	25 ; MIPS32-LABEL: uncond1

	26 ; MIPS32: b 8 <.Luncond1$__1>
	Jim Stichnoth 2016/02/23 06:18:51 Does the "8" refer to a byte offset within the fun Does the "8" refer to a byte offset within the function? If so, you probably want to future-proof this because offsets are likely to change once the prolog is implemented. E.g.: ; MIPS32: b {{.}} <.Luncond1$__1> BTW, I made the comment about providing a trivial definition of Label::getName() for a MINIMAL build, but I guess that would be a problem here because this lit test is run in MINIMAL builds... rkotlerimgtec* 2016/02/23 23:17:20 i'm not exactly sure what the 8 means. it's someth Show quoted text On 2016/02/23 06:18:51, stichnot wrote: > Does the "8" refer to a byte offset within the function? If so, you probably > want to future-proof this because offsets are likely to change once the prolog > is implemented. E.g.: > > ; MIPS32: b {{.*}} <.Luncond1$__1> > > BTW, I made the comment about providing a trivial definition of Label::getName() > for a MINIMAL build, but I guess that would be a problem here because this lit > test is run in MINIMAL builds... i'm not exactly sure what the 8 means. it's something from the objdump program. i'm just emitting a branch in assembly to a label.
	27 ; MIPS32: <.Luncond1$__1>:

	28 ; MIPS32: li

	29 ; MIPS32: addu

	30 ; MIPS32: b 8 <.Luncond1$__1>

	31
	Jim Stichnoth 2016/02/23 06:18:51 Just remove the rest of this. Just remove the rest of this. rkotlerimgtec 2016/02/23 23:17:20 Done. Show quoted text On 2016/02/23 06:18:51, stichnot wrote: > Just remove the rest of this. Done.
	32 define internal i32 @nacl_tp_tdb_offset(i32) {

	33 entry:

	34 ret i32 0

	35 }

	36

	37 define internal i32 @nacl_tp_tls_offset(i32 %size) {

	38 entry:

	39 %result = sub i32 0, %size

	40 ret i32 %result

	41 }

OLD	NEW

« src/IceInstMIPS32.cpp ('K') | « src/IceTargetLoweringMIPS32.cpp ('k') | no next file » | no next file with comments »