Subzero: Basic unconditional branch for Mips.

src/IceInstMIPS32.cpp

 //===- subzero/src/IceInstMips32.cpp - Mips32 instruction implementation --===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 /// \file
@@ skipping 88 matching lines @@
     return;
   emitThreeAddrLoHi(Opcode, this, Func);
 }
 
 template <> void InstMIPS32Multu::emit(const Cfg *Func) const {
   if (!BuildDefs::dump())
     return;
   emitThreeAddrLoHi(Opcode, this, Func);
 }
 
+InstMIPS32Br::InstMIPS32Br(Cfg *Func, const CfgNode *TargetTrue,
+                           const CfgNode *TargetFalse,
+                           const InstMIPS32Label *Label)
+    : InstMIPS32(Func, InstMIPS32::Br, 0, nullptr), TargetTrue(TargetTrue),
+      TargetFalse(TargetFalse), Label(Label) {}
+
+InstMIPS32Label::InstMIPS32Label(Cfg *Func, TargetMIPS32 *Target)

[Jim Stichnoth, 2016/02/23 06:18:51]

You may want to consider alphabetizing or otherwise organizing the methods here.
 Your call.

[rkotlerimgtec, 2016/02/23 23:17:20]

Let's alphabetize in another patch. Otherwise it will make it hard to see what
is going on in this patch. I will do it right away after this patch.

+    : InstMIPS32(Func, InstMIPS32::Label, 0, nullptr),
+      Number(Target->makeNextLabelNumber()) {}
+
+IceString InstMIPS32Label::getName(const Cfg *Func) const {
+  return ".L" + Func->getFunctionName() + "$local$__" + std::to_string(Number);

[Jim Stichnoth, 2016/02/23 06:18:51]

This method should probably start with something like:

  if (!BuildDefs::dump())
    return IceString();

And while you're at it, maybe do the same for InstX86Label::getName() and
InstARM32Label::getName() ?

[rkotlerimgtec, 2016/02/23 23:17:20]

Done.

+}
+
 InstMIPS32Call::InstMIPS32Call(Cfg *Func, Variable *Dest, Operand *CallTarget)
     : InstMIPS32(Func, InstMIPS32::Call, 1, Dest) {
   HasSideEffects = true;
   addSource(CallTarget);
 }
 
 InstMIPS32Mov::InstMIPS32Mov(Cfg *Func, Variable *Dest, Operand *Src)
     : InstMIPS32(Func, InstMIPS32::Mov, 2, Dest) {
   auto *Dest64 = llvm::dyn_cast<Variable64On32>(Dest);
   auto *Src64 = llvm::dyn_cast<Variable64On32>(Src);
@@ skipping 99 matching lines @@
   auto *RA = llvm::cast<Variable>(getSrc(0));
   assert(RA->hasReg());
   assert(RA->getRegNum() == RegMIPS32::Reg_RA);
   Ostream &Str = Func->getContext()->getStrEmit();
   Str << "\t"
          "jr"
          "\t";
   RA->emit(Func);
 }
 
+void InstMIPS32Br::emit(const Cfg *Func) const {
+  if (!BuildDefs::dump())
+    return;
+  Ostream &Str = Func->getContext()->getStrEmit();
+  Str << "\t"
+         "b"
+      << "\t";
+  if (Label) {
+    Str << Label->getName(Func);
+  } else {
+    if (isUnconditionalBranch()) {
+      Str << getTargetFalse()->getAsmName();
+    } else {
+    }

[Jim Stichnoth, 2016/02/23 06:18:51]

Leave something here, like a TODO or an assert?

[rkotlerimgtec, 2016/02/23 23:17:20]

Done.

+  }
+}
+
 void InstMIPS32Call::emit(const Cfg *Func) const {
   if (!BuildDefs::dump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 1);
   if (llvm::isa<ConstantInteger32>(getCallTarget())) {
     // This shouldn't happen (typically have to copy the full 32-bits to a
     // register and do an indirect jump).
     llvm::report_fatal_error("MIPS2Call to ConstantInteger32");
   } else if (const auto *CallTarget =
@@ skipping 154 matching lines @@
   }
 
   Str << "\t";
   getDest()->emit(Func);
   Str << ", ";
   getSrc(0)->emit(Func);
 }
 
 } // end of namespace MIPS32
 } // end of namespace Ice