Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(146)

Issue 1724593002: Fix broken code passing typed data from Dart to V8. Attempted to match patterns in SerializeScriptV… (Closed)

Created:
3 years, 5 months ago by Jacob
Modified:
3 years, 5 months ago
Reviewers:
Alan Knight, terry
CC:
reviews+dom_dartlang.org
Base URL:
https://chromium.googlesource.com/dart/dartium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix broken code passing typed data from Dart to V8. Attempted to match patterns in SerializeScriptValue.cpp Fix JS interop to properly set set a hidden value when passing a Dart function to JS so that JS interop behavior is more consistent on dart2js and dartium. BUG= R=terry@google.com Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=f9521e3417d117a76e928778057adf8d2a7cd516

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -16 lines) Patch
M Source/bindings/core/dart/DartJsInterop.cpp View 4 chunks +8 lines, -5 lines 0 comments Download
M Source/bindings/core/dart/V8Converter.cpp View 2 chunks +54 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
JS interop fixes that enable pop-pop-win and fix tests that were expecting to call functions ...
3 years, 5 months ago (2016-02-23 01:31:56 UTC) #2
terry
wow lgtm I'll try with some of the file tests too.
3 years, 5 months ago (2016-02-23 15:30:07 UTC) #3
terry
3 years, 5 months ago (2016-02-24 16:10:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f9521e3417d117a76e928778057adf8d2a7cd516 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698