Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1724503002: Add dest type hint to SkShader::ContextRec (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add dest type hint to SkShader::ContextRec Let SkBlitter decide which dst type is optimal (PMColor vs PM4f), and pass that info to shaders. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1724503002 Committed: https://skia.googlesource.com/skia/+/d0c4e092d54d281991ecfdc2e4ddd5217e45b42a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -11 lines) Patch
M bench/SkLinearBitmapPipelineBench.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/SkLinearBitmapPipelineGM.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M include/core/SkShader.h View 2 chunks +14 lines, -5 lines 0 comments Download
M src/core/SkBlitter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkBlitter.cpp View 3 chunks +14 lines, -2 lines 0 comments Download
M src/core/SkDraw.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/SkColor4fTest.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
f(malita)
4 years, 10 months ago (2016-02-22 19:52:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724503002/1
4 years, 10 months ago (2016-02-22 19:52:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-22 20:27:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724503002/1
4 years, 10 months ago (2016-02-23 00:55:49 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-23 00:55:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/6794)
4 years, 10 months ago (2016-02-23 00:57:00 UTC) #11
reed1
lgtm
4 years, 10 months ago (2016-02-23 01:18:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724503002/1
4 years, 10 months ago (2016-02-23 01:18:30 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 01:19:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d0c4e092d54d281991ecfdc2e4ddd5217e45b42a

Powered by Google App Engine
This is Rietveld 408576698