Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: components/leveldb/env_mojo.cc

Issue 1724493003: mojo leveldb: Address some comments that came after it was put in the CQ. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile failure Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/filesystem/lock_table.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/leveldb/env_mojo.cc
diff --git a/components/leveldb/env_mojo.cc b/components/leveldb/env_mojo.cc
index fd8acf3859b663212275cb358aab49e1e24227d1..b7218ace6cb3d1dbda4c21b89812a0748f71d79e 100644
--- a/components/leveldb/env_mojo.cc
+++ b/components/leveldb/env_mojo.cc
@@ -43,7 +43,7 @@ class MojoFileLock : public FileLock {
: fname_(name), lock_(lock) {}
~MojoFileLock() override { DCHECK(!lock_); }
- const std::string& name() { return fname_; }
+ const std::string& name() const { return fname_; }
LevelDBFileThread::OpaqueLock* TakeLock() {
LevelDBFileThread::OpaqueLock* to_return = lock_;
@@ -176,9 +176,6 @@ class MojoWritableFile : public leveldb::WritableFile {
leveldb_env::kWritableFileSync, error);
}
- // TODO(erg): In the leveldb_env::ChromiumEnv, there is a whole system
- // which makes backups of the data here. crbug.com/587185
-
// leveldb's implicit contract for Sync() is that if this instance is for a
// manifest file then the directory is also sync'ed. See leveldb's
// env_posix.cc.
« no previous file with comments | « components/filesystem/lock_table.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698