Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 1724493003: mojo leveldb: Address some comments that came after it was put in the CQ. (Closed)

Created:
4 years, 10 months ago by Elliot Glaysher
Modified:
4 years, 10 months ago
Reviewers:
jam, cmumford
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo leveldb: Address some comments that came after it was put in the CQ. BUG=585587, 587185 Committed: https://crrev.com/cf4ed86e0ba30a44f60d8e7a40fa0721090bef47 Cr-Commit-Position: refs/heads/master@{#377046}

Patch Set 1 #

Patch Set 2 : compile failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -44 lines) Patch
M components/filesystem/directory_impl.cc View 4 chunks +14 lines, -38 lines 0 comments Download
M components/filesystem/lock_table.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M components/leveldb/env_mojo.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Elliot Glaysher
4 years, 10 months ago (2016-02-23 00:19:25 UTC) #3
cmumford
lgtm
4 years, 10 months ago (2016-02-23 15:28:46 UTC) #4
jam
lgtm
4 years, 10 months ago (2016-02-23 16:56:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724493003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724493003/20001
4 years, 10 months ago (2016-02-23 18:13:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-23 19:23:53 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 19:26:13 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf4ed86e0ba30a44f60d8e7a40fa0721090bef47
Cr-Commit-Position: refs/heads/master@{#377046}

Powered by Google App Engine
This is Rietveld 408576698