Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1724493002: fix unsigned/signed warning on linux for GrVkDescriptorPool::numPoolSizes() (Closed)

Created:
4 years, 10 months ago by bsalomon
Modified:
4 years, 10 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@vkgyp
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix unsigned/signed warning on linux for GrVkDescriptorPool::numPoolSizes() BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1724493002 Committed: https://skia.googlesource.com/skia/+/bc2f4dfd4175bd35961092bbbbeccee77dc8aa04

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/gpu/vk/GrVkDescriptorPool.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkDescriptorPool.cpp View 2 chunks +3 lines, -3 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
bsalomon
https://codereview.chromium.org/1724493002/diff/1/src/gpu/vk/GrVkDescriptorPool.cpp File src/gpu/vk/GrVkDescriptorPool.cpp (right): https://codereview.chromium.org/1724493002/diff/1/src/gpu/vk/GrVkDescriptorPool.cpp#newcode27 src/gpu/vk/GrVkDescriptorPool.cpp:27: SkASSERT(currentPool == numPools); this assert barfs on linux currently.
4 years, 10 months ago (2016-02-22 19:50:33 UTC) #3
egdaniel
lgtm
4 years, 10 months ago (2016-02-22 19:53:52 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1718273002 Patch 1). Please resolve the dependency and ...
4 years, 10 months ago (2016-02-22 19:59:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724493002/1
4 years, 10 months ago (2016-02-22 20:45:32 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 21:09:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bc2f4dfd4175bd35961092bbbbeccee77dc8aa04

Powered by Google App Engine
This is Rietveld 408576698