Issue 1724463003: refactor: avoid parts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1724463003: refactor: avoid parts (Closed)

Created:
4 years, 10 months ago by Jennifer Messerly

Modified:
4 years, 10 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

refactor: avoid parts we try to avoid "parts" except in js_ast (because that will be split out into its own package) R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/a1957208282c19e09ed85e167f7f0e65813c6cde

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+282 lines, -41 lines)			Patch
M	lib/src/codegen/js_codegen.dart	View	16 chunks	+20 lines, -33 lines	0 comments	Download
M	lib/src/codegen/js_interop.dart	View	2 chunks	+15 lines, -1 line	0 comments	Download
M	lib/src/codegen/js_typeref_codegen.dart	View	4 chunks	+12 lines, -7 lines	0 comments	Download
A	test/codegen/expect/collection/src/queue_list.js	View	1 chunk	+235 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

4 years, 10 months ago (2016-02-23 00:01:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a1957208282c19e09ed85e167f7f0e65813c6cde (presubmit successful).