[MD] Don't allow overflowing location icons to appear on top of toolbar

chrome/browser/ui/views/location_bar/location_bar_view.cc

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index 7adaf3fb21df88758a56c51d7105faf07dcd19cf..54d17bed84f24be3c9667050ba78fce82f4f8272 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -179,7 +179,12 @@ void LocationBarView::Init() {
   // not prepared for that.
   DCHECK(GetWidget());
 
-  if (!ui::MaterialDesignController::IsModeMaterial()) {
+  if (ui::MaterialDesignController::IsModeMaterial()) {
+    // Make sure children with layers are clipped.
+    SetPaintToLayer(true);

[bruthig, 2016/02/24 17:02:58]

Calling SetPaintToLayer(true) causes the View to create a
LayerType::LAYER_TEXTURED Layer which does have some associated costs, however,
I don't think View will currently work with a LAYER_NOT_DRAWN type Layer.  I
have filed http://crbug.com/589497 to address this issue on a more general
basis.  I suspect that it will require at least a moderate amount of effort to
solve this in the general case.
Can you add a TODO here (and maybe in the two other spots that use this
technique) that references that bug?

[Evan Stade, 2016/02/24 23:14:17]

done. (Only two spots use this technique AFAIK --- the infobar is a special case
as even without layers we had to do a special dance for clipping. This is a
result of the funky shape necessary to draw the arrow.)

+    SetFillsBoundsOpaquely(false);
+    layer()->SetMasksToBounds(true);
+  } else {

[Peter Kasting, 2016/02/24 01:46:08]

Nit: Can combine this else with subsequent if and flatten to one three-arm
conditional

[Evan Stade, 2016/02/24 23:14:18]

Done.

     if (is_popup_mode_) {
       const int kOmniboxPopupBorderImages[] =
           IMAGE_GRID(IDR_OMNIBOX_POPUP_BORDER_AND_SHADOW);