Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 172433002: Fixes gyp bindings generator dependencies (Closed)

Created:
6 years, 10 months ago by sky
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Fixes gyp bindings generator dependencies BUG=none TEST=none R=darin@chromium.org, davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M mojo/public/bindings/mojom_bindings_generator.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
6 years, 10 months ago (2014-02-19 14:26:30 UTC) #1
darin (slow to review)
LGTM
6 years, 10 months ago (2014-02-19 16:45:51 UTC) #2
sky
6 years, 10 months ago (2014-02-19 21:43:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r252103 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698