Issue 17243004: Added test to verify that NTP respects browser language setting.

Issue 17243004: Added test to verify that NTP respects browser language setting. (Closed)

Created:
7 years, 6 months ago by kmadhusu

Modified:
7 years, 6 months ago

Reviewers:
Jered

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added test to verify that NTP respects browser language setting. BUG=246854 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208028

Patch Set 1 #

Patch Set 2 : Test is flaky on linux try bots. Disable it for now. #

Total comments: 4

Patch Set 3 : Rebase #

Patch Set 4 : Addressed comments. #

Patch Set 5 : Rebase #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -0 lines)			Patch
	M	chrome/browser/ui/search/local_ntp_browsertest.cc	View	1 2 3 4	2 chunks	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Jered

https://codereview.chromium.org/17243004/diff/7001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc File chrome/browser/ui/search/instant_extended_interactive_uitest.cc (right): https://codereview.chromium.org/17243004/diff/7001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc#newcode2910 chrome/browser/ui/search/instant_extended_interactive_uitest.cc:2910: MAYBE_NTPRespectsBrowserLanguageSetting) { Put this test in local_ntp_browsertest. https://codereview.chromium.org/17243004/diff/7001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc#newcode2912 chrome/browser/ui/search/instant_extended_interactive_uitest.cc:2912: ...

7 years, 6 months ago (2013-06-19 22:29:31 UTC) #2

kmadhusu

PTAL. Thanks. https://codereview.chromium.org/17243004/diff/7001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc File chrome/browser/ui/search/instant_extended_interactive_uitest.cc (right): https://codereview.chromium.org/17243004/diff/7001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc#newcode2910 chrome/browser/ui/search/instant_extended_interactive_uitest.cc:2910: MAYBE_NTPRespectsBrowserLanguageSetting) { On 2013/06/19 22:29:32, Jered wrote: ...

7 years, 6 months ago (2013-06-21 18:27:58 UTC) #3

Jered

On 2013/06/21 18:27:58, kmadhusu wrote: > PTAL. > > Thanks. > > https://codereview.chromium.org/17243004/diff/7001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc > File ...

7 years, 6 months ago (2013-06-21 18:34:55 UTC) #4