Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1724283004: Regenerate `ErrorCode` enum. (Closed)

Created:
4 years, 10 months ago by pquitslund
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 10 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 10 months ago (2016-02-24 17:34:07 UTC) #2
Brian Wilkerson
LGTM, although we should just solve the problem generally. What about adding codes in the ...
4 years, 10 months ago (2016-02-24 18:14:12 UTC) #3
pquitslund
On 2016/02/24 18:14:12, Brian Wilkerson wrote: > LGTM, although we should just solve the problem ...
4 years, 10 months ago (2016-02-24 18:21:26 UTC) #4
pquitslund
4 years, 10 months ago (2016-02-24 18:23:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
268c35ae1da724a79ef6af06d473f0942a7e6e5b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698