Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1724283003: Revert of Simple cleanups related to SkFixed. (Closed)

Created:
4 years, 10 months ago by dogben
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
bungeman-skia, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Simple cleanups related to SkFixed. (patchset #4 id:120001 of https://codereview.chromium.org/1683743005/ ) Reason for revert: New test is failing on Windows. Original issue's description: > Cleanups related to SkFixed. > > Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float. > > Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3. > > Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB. > > BUG=skia:4632 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005 > > Committed: https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c TBR=mtklein@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4632 Committed: https://skia.googlesource.com/skia/+/c2d35d851365bb89f392fe2dd7af57e169de26b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -91 lines) Patch
M include/core/SkFixed.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkRect.h View 1 chunk +2 lines, -1 line 0 comments Download
M samplecode/SampleText.cpp View 2 chunks +37 lines, -0 lines 0 comments Download
M src/core/SkBitmapFilter.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 chunk +0 lines, -1 line 0 comments Download
D tests/PaintBreakTextTest.cpp View 1 chunk +0 lines, -88 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dogben
Created Revert of Simple cleanups related to SkFixed.
4 years, 10 months ago (2016-02-24 16:28:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724283003/1
4 years, 10 months ago (2016-02-24 16:29:00 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 16:29:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c2d35d851365bb89f392fe2dd7af57e169de26b7

Powered by Google App Engine
This is Rietveld 408576698