Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1724193002: Update settings string for enabling network predictions. (Closed)

Created:
4 years, 10 months ago by newt (away)
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update settings string for enabling network predictions. BUG=585297 Committed: https://crrev.com/e40cf6154c893214099ac7ad0b8b4d4babbd3cd5 Cr-Commit-Position: refs/heads/master@{#377336}

Patch Set 1 #

Total comments: 4

Patch Set 2 : igrigorik's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/app/settings_strings.grdp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/components_chromium_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/components_google_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/components_settings_strings.grdp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
newt (away)
PTAL
4 years, 10 months ago (2016-02-23 22:24:19 UTC) #2
newt (away)
+blundell for components OWNERS
4 years, 10 months ago (2016-02-23 22:25:16 UTC) #4
newt (away)
+dschuyler for settings_strings.grdp
4 years, 10 months ago (2016-02-23 22:26:45 UTC) #6
newt (away)
igrigorik: Is there a bug I can link to specifically for the string change?
4 years, 10 months ago (2016-02-23 22:28:17 UTC) #7
dschuyler
lgtm
4 years, 10 months ago (2016-02-23 22:35:04 UTC) #8
igrigorik
lgtm lgtm. One minor suggestion, feel free to ignore. https://codereview.chromium.org/1724193002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1724193002/diff/1/chrome/app/settings_strings.grdp#newcode407 chrome/app/settings_strings.grdp:407: ...
4 years, 10 months ago (2016-02-23 22:48:19 UTC) #9
igrigorik
On 2016/02/23 22:28:17, newt wrote: > igrigorik: Is there a bug I can link to ...
4 years, 10 months ago (2016-02-23 22:48:58 UTC) #10
newt (away)
https://codereview.chromium.org/1724193002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1724193002/diff/1/chrome/app/settings_strings.grdp#newcode407 chrome/app/settings_strings.grdp:407: <message name="IDS_SETTINGS_NETWORK_PREDICTION_ENABLED_DESCRIPTION" desc="In the advanced options tab, the text ...
4 years, 10 months ago (2016-02-23 23:02:05 UTC) #11
blundell
lgtm
4 years, 10 months ago (2016-02-24 12:25:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724193002/20001
4 years, 10 months ago (2016-02-24 17:42:32 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-24 18:59:46 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 19:01:47 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e40cf6154c893214099ac7ad0b8b4d4babbd3cd5
Cr-Commit-Position: refs/heads/master@{#377336}

Powered by Google App Engine
This is Rietveld 408576698