Issue 1724053002: some analyzer fixes for compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1724053002: some analyzer fixes for compiler (Closed)

Created:
4 years, 10 months ago by kevmoo

Modified:
4 years, 10 months ago

Reviewers:
Johnni Winther, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -23 lines)			Patch
M	pkg/compiler/lib/src/serialization/element_serialization.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/serialization/modelz.dart	View	6 chunks	+0 lines, -21 lines	0 comments	Download
M	pkg/compiler/samples/jsonify/jsonify.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 6 (3 generated)

Siggi Cherem (dart-lang)

+johnni lgtm Johnni - just FYI - the changes in modelz appear correct to me, ...

4 years, 10 months ago (2016-02-23 20:27:54 UTC) #4

kevmoo

4 years, 10 months ago (2016-02-24 15:40:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1c051f6c0fa818dab82dbcf65deb30fca1d19108 (presubmit successful).