Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1724043002: Re-enable validation for asm->wasm embechen tests. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-enable validation for asm->wasm embechen tests. Now that register validation is working again, re-enable for asm->wasm embenchen tests. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/74cf7300988620be5ade0a2566bec7adb78e21dc Cr-Commit-Position: refs/heads/master@{#34223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M test/mjsunit/wasm/embenchen/box2d.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/embenchen/copy.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/embenchen/corrections.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/embenchen/fannkuch.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/embenchen/fasta.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/embenchen/lua_binarytrees.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/embenchen/memops.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/embenchen/primes.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/embenchen/zlib.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bradn
4 years, 10 months ago (2016-02-23 18:31:02 UTC) #2
titzer
lgtm
4 years, 10 months ago (2016-02-23 18:32:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724043002/1
4 years, 10 months ago (2016-02-23 18:52:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 19:05:06 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 19:06:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74cf7300988620be5ade0a2566bec7adb78e21dc
Cr-Commit-Position: refs/heads/master@{#34223}

Powered by Google App Engine
This is Rietveld 408576698