Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_util_unittest.cc

Issue 172393005: [safe browsing] Remove stale BINHASH code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update histogram info in comment. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_util_unittest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc
index 20b033ba186b2acc41abc4d2767572779aa46b32..f0763fed7901f5d0cd29d5ed9afdb262e58e49c7 100644
--- a/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc
@@ -316,13 +316,6 @@ TEST(SafeBrowsingUtilTest, ListIdListNameConversion) {
EXPECT_EQ(list_name, std::string(safe_browsing_util::kBinUrlList));
EXPECT_EQ(safe_browsing_util::BINURL,
safe_browsing_util::GetListId(list_name));
-
-
- EXPECT_TRUE(safe_browsing_util::GetListName(safe_browsing_util::BINHASH,
- &list_name));
- EXPECT_EQ(list_name, std::string(safe_browsing_util::kBinHashList));
- EXPECT_EQ(safe_browsing_util::BINHASH,
- safe_browsing_util::GetListId(list_name));
}
// Since the ids are saved in file, we need to make sure they don't change.
@@ -332,7 +325,6 @@ TEST(SafeBrowsingUtilTest, ListIdVerification) {
EXPECT_EQ(0, safe_browsing_util::MALWARE % 2);
EXPECT_EQ(1, safe_browsing_util::PHISH % 2);
EXPECT_EQ(0, safe_browsing_util::BINURL %2);
- EXPECT_EQ(1, safe_browsing_util::BINHASH % 2);
}
TEST(SafeBrowsingUtilTest, StringToSBFullHashAndSBFullHashToString) {
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698