Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1723913003: GN: Normalize the build directory path (Closed)

Created:
4 years, 10 months ago by hashimoto
Modified:
4 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Normalize the build directory path BUG=586906 TEST=ln -s /tmp out_tmp && out/gn/gn gen //out_tmp/Release Committed: https://crrev.com/f1c6101de0ecd583fd47fdc69a2a241367e49b7b Cr-Commit-Position: refs/heads/master@{#377175}

Patch Set 1 : Original patch https://codereview.chromium.org/1707293002 #

Patch Set 2 : Create directory before realpath() #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M tools/gn/setup.cc View 1 3 chunks +41 lines, -3 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
hashimoto
https://codereview.chromium.org/1723913003/diff/20001/tools/gn/setup.cc File tools/gn/setup.cc (right): https://codereview.chromium.org/1723913003/diff/20001/tools/gn/setup.cc#newcode230 tools/gn/setup.cc:230: bool GetRealPath(const base::FilePath& path, base::FilePath* out) { Renamed this ...
4 years, 10 months ago (2016-02-23 10:17:31 UTC) #2
brettw
lgtm
4 years, 10 months ago (2016-02-24 00:25:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723913003/20001
4 years, 10 months ago (2016-02-24 00:29:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-24 01:24:10 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 01:26:29 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f1c6101de0ecd583fd47fdc69a2a241367e49b7b
Cr-Commit-Position: refs/heads/master@{#377175}

Powered by Google App Engine
This is Rietveld 408576698