Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17239008: Remove XPathException (Closed)

Created:
7 years, 6 months ago by arv (Not doing code reviews)
Modified:
7 years, 6 months ago
Reviewers:
jsbell, abarth-chromium
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Remove XPathException Instead of throwing XPathException we throw DOMException and ordinary TypeError. The goal is to remove all exception classes except DOMException. We now match Firefox. BUG=251323 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152669

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -291 lines) Patch
M LayoutTests/dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js View 2 chunks +2 lines, -2 lines 2 comments Download
M LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/svg/level3/xpath/XPathResult_TYPE_ERR.js View 52 chunks +52 lines, -52 lines 0 comments Download
M LayoutTests/fast/dom/DOMException/XPathException-expected.txt View 1 chunk +6 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/DOMException/resources/XPathException.js View 2 chunks +6 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/Window/resources/window-properties.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/xpath/4XPath/Core/test_parser-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/xpath/invalid-functions-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/xpath/py-dom-xpath/expressions-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/inspector/console/console-dir-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/dom/DOMExceptions.in View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/xml/XPathException.h View 1 chunk +0 lines, -64 lines 0 comments Download
D Source/core/xml/XPathException.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
D Source/core/xml/XPathException.idl View 1 chunk +0 lines, -44 lines 0 comments Download
M Source/core/xml/XPathExpression.cpp View 1 2 chunks +2 lines, -4 lines 2 comments Download
M Source/core/xml/XPathParser.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/xml/XPathResult.cpp View 10 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
arv (Not doing code reviews)
https://codereview.chromium.org/17239008/diff/3001/Source/core/xml/XPathExpression.cpp File Source/core/xml/XPathExpression.cpp (right): https://codereview.chromium.org/17239008/diff/3001/Source/core/xml/XPathExpression.cpp#newcode76 Source/core/xml/XPathExpression.cpp:76: ec = SYNTAX_ERR; It seems like TypeError would be ...
7 years, 6 months ago (2013-06-18 19:15:05 UTC) #1
abarth-chromium
classes exceptio DOMException ^^^ except
7 years, 6 months ago (2013-06-18 19:28:37 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/17239008/diff/3001/LayoutTests/dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js File LayoutTests/dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js (right): https://codereview.chromium.org/17239008/diff/3001/LayoutTests/dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js#newcode110 LayoutTests/dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js:110: success = ex.name == 'SyntaxError'; This looks like ...
7 years, 6 months ago (2013-06-18 19:30:33 UTC) #3
arv (Not doing code reviews)
https://codereview.chromium.org/17239008/diff/3001/LayoutTests/dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js File LayoutTests/dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js (right): https://codereview.chromium.org/17239008/diff/3001/LayoutTests/dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js#newcode110 LayoutTests/dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js:110: success = ex.name == 'SyntaxError'; On 2013/06/18 19:30:33, abarth ...
7 years, 6 months ago (2013-06-18 19:34:29 UTC) #4
abarth-chromium
Ok. Let's modify the test.
7 years, 6 months ago (2013-06-18 19:44:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/17239008/3001
7 years, 6 months ago (2013-06-18 19:56:09 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-18 22:37:53 UTC) #7
Message was sent while issue was closed. 
Change committed as 152669

Powered by Google App Engine
This is Rietveld 408576698