Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1723803004: [interpreter, debugger] replace bytecode on-stack for debugging. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
Reviewers:
mcilroy, rmcilroy
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter, debugger] replace bytecode on-stack for debugging. R=mcilroy@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/72ba53b19afdfeeeb072daf426d3c8fd78a217a2 Cr-Commit-Position: refs/heads/master@{#34210}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -18 lines) Patch
M src/debug/debug.cc View 1 5 chunks +30 lines, -9 lines 0 comments Download
A + test/mjsunit/ignition/debug-break-on-stack.js View 1 chunk +11 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Yang
4 years, 10 months ago (2016-02-23 10:07:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723803004/1
4 years, 10 months ago (2016-02-23 10:22:41 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/14086) v8_linux64_avx2_rel on ...
4 years, 10 months ago (2016-02-23 10:33:34 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723803004/20001
4 years, 10 months ago (2016-02-23 12:47:04 UTC) #7
rmcilroy
LGTM, thanks!
4 years, 10 months ago (2016-02-23 12:52:36 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 13:08:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723803004/20001
4 years, 10 months ago (2016-02-23 13:09:39 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-23 13:10:54 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 13:11:41 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/72ba53b19afdfeeeb072daf426d3c8fd78a217a2
Cr-Commit-Position: refs/heads/master@{#34210}

Powered by Google App Engine
This is Rietveld 408576698