Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: content/renderer/render_view_impl.h

Issue 1723763002: Add WebDragData to blink::WebView::dragtargetDrop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add is_valid to dropdata Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index bee1c6571d95f91fb80d4e8b44c947931270aa92..60af92c09d37b2b4e556c4288746269618a5f356 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -626,9 +626,17 @@ class CONTENT_EXPORT RenderViewImpl
const gfx::Point& screen_point,
blink::WebDragOperation drag_operation);
void OnDragSourceSystemDragEnded();
- void OnDragTargetDrop(const gfx::Point& client_pt,
+ // |drop_data| will only be used when drop data is valid. This is
+ // because on most platforms (Aura), the drop data is available when the drag
+ // starts and stays the same until it's dropped. On Android, the drop data is
+ // unavailable until DragTargetDrop. So on Android, |drop_data| will contain
+ // the real data.
+ void OnDragTargetDrop(const content::DropData& drop_data,
+ const gfx::Point& client_pt,
const gfx::Point& screen_pt,
int key_modifiers);
+ // On Android, |drop_data| will contain dummy data because drop data is
+ // unavailable until 'drop' action.
void OnDragTargetDragEnter(const DropData& drop_data,
const gfx::Point& client_pt,
const gfx::Point& screen_pt,

Powered by Google App Engine
This is Rietveld 408576698