third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 1723763002: Add WebDragData to blink::WebView::dragtargetDrop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 1723763002: Add WebDragData to blink::WebView::dragtargetDrop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use static factory methods Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index b8cd9a1a3a0e1098d30747a50eb51dd1a129359d..c91a67aec6c5648a874930fc6d771481264f9315 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -3710,11 +3710,12 @@ void WebViewImpl::dragTargetDragLeave()

m_currentDragData = nullptr;

}

-void WebViewImpl::dragTargetDrop(const WebPoint& clientPoint,

- const WebPoint& screenPoint,

- int modifiers)

+void WebViewImpl::dragTargetDrop(const WebDragData& webDragData, const WebPoint& clientPoint,

+ const WebPoint& screenPoint,

+ int modifiers)

{

DCHECK(m_currentDragData);

+ m_currentDragData = DataObject::create(webDragData);

WebAutofillClient* autofillClient = mainFrameImpl() ? mainFrameImpl()->autofillClient() : 0;

UserGestureNotifier notifier(autofillClient, &m_userGestureObserved);