content/browser/web_contents/web_drag_dest_mac.mm - Issue 1723763002: Add WebDragData to blink::WebView::dragtargetDrop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_drag_dest_mac.mm

Issue 1723763002: Add WebDragData to blink::WebView::dragtargetDrop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_drag_dest_mac.mm

diff --git a/content/browser/web_contents/web_drag_dest_mac.mm b/content/browser/web_contents/web_drag_dest_mac.mm

index ec3b00035ddbea2fe261fc4456aab6320a9c8158..55b48d3b397ca0340d269ef01a4673459bbe13eb 100644

--- a/content/browser/web_contents/web_drag_dest_mac.mm

+++ b/content/browser/web_contents/web_drag_dest_mac.mm

@@ -254,9 +254,8 @@ int GetModifierFlags() {

NSPoint viewPoint = [self flipWindowPointToView:windowPoint view:view];

NSPoint screenPoint = [self flipWindowPointToScreen:windowPoint view:view];

webContents_->GetRenderViewHost()->DragTargetDrop(

- gfx::Point(viewPoint.x, viewPoint.y),

- gfx::Point(screenPoint.x, screenPoint.y),

- GetModifierFlags());

+ *dropData_, gfx::Point(viewPoint.x, viewPoint.y),

+ gfx::Point(screenPoint.x, screenPoint.y), GetModifierFlags());

dropData_.reset();