Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1861)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 1723763002: Add WebDragData to blink::WebView::dragtargetDrop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use static factory methods Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_view_host_impl.h" 5 #include "content/browser/renderer_host/render_view_host_impl.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 #include "content/public/common/file_chooser_file_info.h" 73 #include "content/public/common/file_chooser_file_info.h"
74 #include "content/public/common/file_chooser_params.h" 74 #include "content/public/common/file_chooser_params.h"
75 #include "content/public/common/result_codes.h" 75 #include "content/public/common/result_codes.h"
76 #include "content/public/common/url_constants.h" 76 #include "content/public/common/url_constants.h"
77 #include "content/public/common/url_utils.h" 77 #include "content/public/common/url_utils.h"
78 #include "net/base/filename_util.h" 78 #include "net/base/filename_util.h"
79 #include "net/base/url_util.h" 79 #include "net/base/url_util.h"
80 #include "net/url_request/url_request_context_getter.h" 80 #include "net/url_request/url_request_context_getter.h"
81 #include "storage/browser/fileapi/isolated_context.h" 81 #include "storage/browser/fileapi/isolated_context.h"
82 #include "third_party/skia/include/core/SkBitmap.h" 82 #include "third_party/skia/include/core/SkBitmap.h"
83 #include "ui/base/clipboard/clipboard.h"
83 #include "ui/base/touch/touch_device.h" 84 #include "ui/base/touch/touch_device.h"
84 #include "ui/base/touch/touch_enabled.h" 85 #include "ui/base/touch/touch_enabled.h"
85 #include "ui/base/ui_base_switches.h" 86 #include "ui/base/ui_base_switches.h"
86 #include "ui/gfx/animation/animation.h" 87 #include "ui/gfx/animation/animation.h"
87 #include "ui/gfx/image/image_skia.h" 88 #include "ui/gfx/image/image_skia.h"
88 #include "ui/gfx/native_widget_types.h" 89 #include "ui/gfx/native_widget_types.h"
89 #include "ui/native_theme/native_theme_switches.h" 90 #include "ui/native_theme/native_theme_switches.h"
90 #include "url/url_constants.h" 91 #include "url/url_constants.h"
91 92
92 #if defined(OS_WIN) 93 #if defined(OS_WIN)
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 display::win::GetSystemMetricsInDIP(SM_CXVSCROLL); 158 display::win::GetSystemMetricsInDIP(SM_CXVSCROLL);
158 prefs->horizontal_scroll_bar_height_in_dips = 159 prefs->horizontal_scroll_bar_height_in_dips =
159 display::win::GetSystemMetricsInDIP(SM_CYHSCROLL); 160 display::win::GetSystemMetricsInDIP(SM_CYHSCROLL);
160 prefs->arrow_bitmap_height_vertical_scroll_bar_in_dips = 161 prefs->arrow_bitmap_height_vertical_scroll_bar_in_dips =
161 display::win::GetSystemMetricsInDIP(SM_CYVSCROLL); 162 display::win::GetSystemMetricsInDIP(SM_CYVSCROLL);
162 prefs->arrow_bitmap_width_horizontal_scroll_bar_in_dips = 163 prefs->arrow_bitmap_width_horizontal_scroll_bar_in_dips =
163 display::win::GetSystemMetricsInDIP(SM_CXHSCROLL); 164 display::win::GetSystemMetricsInDIP(SM_CXHSCROLL);
164 } 165 }
165 #endif 166 #endif
166 167
168 std::vector<DropData::Metadata> DropDataToMetaData(const DropData& drop_data) {
169 std::vector<DropData::Metadata> metadata;
170 if (!drop_data.text.is_null()) {
171 metadata.push_back(DropData::Metadata::createForMimeType(
172 DropData::Kind::STRING,
173 base::ASCIIToUTF16(ui::Clipboard::kMimeTypeText)));
174 }
175
176 if (!drop_data.url.is_empty()) {
177 metadata.push_back(DropData::Metadata::createForMimeType(
178 DropData::Kind::STRING,
179 base::ASCIIToUTF16(ui::Clipboard::kMimeTypeURIList)));
180 }
181
182 if (!drop_data.html.is_null()) {
183 metadata.push_back(DropData::Metadata::createForMimeType(
184 DropData::Kind::STRING,
185 base::ASCIIToUTF16(ui::Clipboard::kMimeTypeHTML)));
186 }
187
188 // On Aura, filenames are available before drop.
189 for (const auto& file_info : drop_data.filenames) {
190 if (!file_info.path.empty()) {
191 metadata.push_back(DropData::Metadata::createForFilePath(file_info.path));
192 }
193 }
194
195 // On Android, only files' mime types are available before drop.
196 for (const auto& mime_type : drop_data.file_mime_types) {
197 if (!mime_type.empty()) {
198 metadata.push_back(DropData::Metadata::createForMimeType(
199 DropData::Kind::FILENAME, mime_type));
200 }
201 }
202
203 for (const auto& file_system_file : drop_data.file_system_files) {
204 if (!file_system_file.url.is_empty()) {
205 metadata.push_back(
206 DropData::Metadata::createForFileSystemUrl(file_system_file.url));
207 }
208 }
209
210 for (const auto& custom_data_item : drop_data.custom_data) {
211 metadata.push_back(DropData::Metadata::createForMimeType(
212 DropData::Kind::STRING, custom_data_item.first));
213 }
214
215 return metadata;
216 }
217
167 } // namespace 218 } // namespace
168 219
169 // static 220 // static
170 const int64_t RenderViewHostImpl::kUnloadTimeoutMS = 1000; 221 const int64_t RenderViewHostImpl::kUnloadTimeoutMS = 1000;
171 222
172 /////////////////////////////////////////////////////////////////////////////// 223 ///////////////////////////////////////////////////////////////////////////////
173 // RenderViewHost, public: 224 // RenderViewHost, public:
174 225
175 // static 226 // static
176 RenderViewHost* RenderViewHost::FromID(int render_process_id, 227 RenderViewHost* RenderViewHost::FromID(int render_process_id,
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
584 GetWidget()->RendererExited(status, exit_code); 635 GetWidget()->RendererExited(status, exit_code);
585 delegate_->RenderViewTerminated(this, status, exit_code); 636 delegate_->RenderViewTerminated(this, status, exit_code);
586 } 637 }
587 638
588 void RenderViewHostImpl::DragTargetDragEnter( 639 void RenderViewHostImpl::DragTargetDragEnter(
589 const DropData& drop_data, 640 const DropData& drop_data,
590 const gfx::Point& client_pt, 641 const gfx::Point& client_pt,
591 const gfx::Point& screen_pt, 642 const gfx::Point& screen_pt,
592 WebDragOperationsMask operations_allowed, 643 WebDragOperationsMask operations_allowed,
593 int key_modifiers) { 644 int key_modifiers) {
594 const int renderer_id = GetProcess()->GetID(); 645 Send(new DragMsg_TargetDragEnter(
595 ChildProcessSecurityPolicyImpl* policy = 646 GetRoutingID(), DropDataToMetaData(drop_data), client_pt, screen_pt,
596 ChildProcessSecurityPolicyImpl::GetInstance(); 647 operations_allowed, key_modifiers));
597
598 #if defined(OS_CHROMEOS)
599 // The externalfile:// scheme is used in Chrome OS to open external files in a
600 // browser tab.
601 if (drop_data.url.SchemeIs(content::kExternalFileScheme))
602 policy->GrantRequestURL(renderer_id, drop_data.url);
603 #endif
604
605 // The URL could have been cobbled together from any highlighted text string,
606 // and can't be interpreted as a capability.
607 DropData filtered_data(drop_data);
608 GetProcess()->FilterURL(true, &filtered_data.url);
609 if (drop_data.did_originate_from_renderer) {
610 filtered_data.filenames.clear();
611 }
612
613 // The filenames vector, on the other hand, does represent a capability to
614 // access the given files.
615 storage::IsolatedContext::FileInfoSet files;
616 for (std::vector<ui::FileInfo>::iterator iter(
617 filtered_data.filenames.begin());
618 iter != filtered_data.filenames.end();
619 ++iter) {
620 // A dragged file may wind up as the value of an input element, or it
621 // may be used as the target of a navigation instead. We don't know
622 // which will happen at this point, so generously grant both access
623 // and request permissions to the specific file to cover both cases.
624 // We do not give it the permission to request all file:// URLs.
625
626 // Make sure we have the same display_name as the one we register.
627 if (iter->display_name.empty()) {
628 std::string name;
629 files.AddPath(iter->path, &name);
630 iter->display_name = base::FilePath::FromUTF8Unsafe(name);
631 } else {
632 files.AddPathWithName(iter->path, iter->display_name.AsUTF8Unsafe());
633 }
634
635 policy->GrantRequestSpecificFileURL(renderer_id,
636 net::FilePathToFileURL(iter->path));
637
638 // If the renderer already has permission to read these paths, we don't need
639 // to re-grant them. This prevents problems with DnD for files in the CrOS
640 // file manager--the file manager already had read/write access to those
641 // directories, but dragging a file would cause the read/write access to be
642 // overwritten with read-only access, making them impossible to delete or
643 // rename until the renderer was killed.
644 if (!policy->CanReadFile(renderer_id, iter->path))
645 policy->GrantReadFile(renderer_id, iter->path);
646 }
647
648 storage::IsolatedContext* isolated_context =
649 storage::IsolatedContext::GetInstance();
650 DCHECK(isolated_context);
651 std::string filesystem_id = isolated_context->RegisterDraggedFileSystem(
652 files);
653 if (!filesystem_id.empty()) {
654 // Grant the permission iff the ID is valid.
655 policy->GrantReadFileSystem(renderer_id, filesystem_id);
656 }
657 filtered_data.filesystem_id = base::UTF8ToUTF16(filesystem_id);
658
659 storage::FileSystemContext* file_system_context =
660 BrowserContext::GetStoragePartition(GetProcess()->GetBrowserContext(),
661 GetSiteInstance())
662 ->GetFileSystemContext();
663 for (size_t i = 0; i < filtered_data.file_system_files.size(); ++i) {
664 storage::FileSystemURL file_system_url =
665 file_system_context->CrackURL(filtered_data.file_system_files[i].url);
666
667 std::string register_name;
668 std::string filesystem_id = isolated_context->RegisterFileSystemForPath(
669 file_system_url.type(), file_system_url.filesystem_id(),
670 file_system_url.path(), &register_name);
671 policy->GrantReadFileSystem(renderer_id, filesystem_id);
672
673 // Note: We are using the origin URL provided by the sender here. It may be
674 // different from the receiver's.
675 filtered_data.file_system_files[i].url =
676 GURL(storage::GetIsolatedFileSystemRootURIString(
677 file_system_url.origin(), filesystem_id, std::string())
678 .append(register_name));
679 }
680
681 Send(new DragMsg_TargetDragEnter(GetRoutingID(), filtered_data, client_pt,
682 screen_pt, operations_allowed,
683 key_modifiers));
684 } 648 }
685 649
686 void RenderViewHostImpl::DragTargetDragOver( 650 void RenderViewHostImpl::DragTargetDragOver(
687 const gfx::Point& client_pt, 651 const gfx::Point& client_pt,
688 const gfx::Point& screen_pt, 652 const gfx::Point& screen_pt,
689 WebDragOperationsMask operations_allowed, 653 WebDragOperationsMask operations_allowed,
690 int key_modifiers) { 654 int key_modifiers) {
691 Send(new DragMsg_TargetDragOver(GetRoutingID(), client_pt, screen_pt, 655 Send(new DragMsg_TargetDragOver(GetRoutingID(), client_pt, screen_pt,
692 operations_allowed, key_modifiers)); 656 operations_allowed, key_modifiers));
693 } 657 }
694 658
695 void RenderViewHostImpl::DragTargetDragLeave() { 659 void RenderViewHostImpl::DragTargetDragLeave() {
696 Send(new DragMsg_TargetDragLeave(GetRoutingID())); 660 Send(new DragMsg_TargetDragLeave(GetRoutingID()));
697 } 661 }
698 662
699 void RenderViewHostImpl::DragTargetDrop( 663 void RenderViewHostImpl::DragTargetDrop(const DropData& drop_data,
700 const gfx::Point& client_pt, 664 const gfx::Point& client_pt,
701 const gfx::Point& screen_pt, 665 const gfx::Point& screen_pt,
702 int key_modifiers) { 666 int key_modifiers) {
703 Send(new DragMsg_TargetDrop(GetRoutingID(), client_pt, screen_pt, 667 DropData drop_data_with_permissions(drop_data);
704 key_modifiers)); 668 GrantFileAccessFromDropData(&drop_data_with_permissions);
669 Send(new DragMsg_TargetDrop(GetRoutingID(), drop_data_with_permissions,
670 client_pt, screen_pt, key_modifiers));
671 }
672
673 void RenderViewHostImpl::FilterDropData(DropData* drop_data) {
674 #if DCHECK_IS_ON()
675 drop_data->view_id = GetRoutingID();
676 #endif // DCHECK_IS_ON()
677
678 GetProcess()->FilterURL(true, &drop_data->url);
679 if (drop_data->did_originate_from_renderer) {
680 drop_data->filenames.clear();
681 }
705 } 682 }
706 683
707 void RenderViewHostImpl::DragSourceEndedAt( 684 void RenderViewHostImpl::DragSourceEndedAt(
708 int client_x, int client_y, int screen_x, int screen_y, 685 int client_x, int client_y, int screen_x, int screen_y,
709 WebDragOperation operation) { 686 WebDragOperation operation) {
710 Send(new DragMsg_SourceEnded(GetRoutingID(), 687 Send(new DragMsg_SourceEnded(GetRoutingID(),
711 gfx::Point(client_x, client_y), 688 gfx::Point(client_x, client_y),
712 gfx::Point(screen_x, screen_y), 689 gfx::Point(screen_x, screen_y),
713 operation)); 690 operation));
714 } 691 }
(...skipping 632 matching lines...) Expand 10 before | Expand all | Expand 10 after
1347 weak_factory_.GetWeakPtr())); 1324 weak_factory_.GetWeakPtr()));
1348 } else { 1325 } else {
1349 render_view_ready_on_process_launch_ = true; 1326 render_view_ready_on_process_launch_ = true;
1350 } 1327 }
1351 } 1328 }
1352 1329
1353 void RenderViewHostImpl::RenderViewReady() { 1330 void RenderViewHostImpl::RenderViewReady() {
1354 delegate_->RenderViewReady(this); 1331 delegate_->RenderViewReady(this);
1355 } 1332 }
1356 1333
1334 void RenderViewHostImpl::GrantFileAccessFromDropData(DropData* drop_data) {
1335 DCHECK_EQ(GetRoutingID(), drop_data->view_id);
1336 const int renderer_id = GetProcess()->GetID();
1337 ChildProcessSecurityPolicyImpl* policy =
1338 ChildProcessSecurityPolicyImpl::GetInstance();
1339
1340 #if defined(OS_CHROMEOS)
1341 // The externalfile:// scheme is used in Chrome OS to open external files in a
1342 // browser tab.
1343 if (drop_data->url.SchemeIs(content::kExternalFileScheme))
1344 policy->GrantRequestURL(renderer_id, drop_data->url);
1345 #endif
1346
1347 // The filenames vector represents a capability to access the given files.
1348 storage::IsolatedContext::FileInfoSet files;
1349 for (auto& filename : drop_data->filenames) {
1350 // Make sure we have the same display_name as the one we register.
1351 if (filename.display_name.empty()) {
1352 std::string name;
1353 files.AddPath(filename.path, &name);
1354 filename.display_name = base::FilePath::FromUTF8Unsafe(name);
1355 } else {
1356 files.AddPathWithName(filename.path,
1357 filename.display_name.AsUTF8Unsafe());
1358 }
1359 // A dragged file may wind up as the value of an input element, or it
1360 // may be used as the target of a navigation instead. We don't know
1361 // which will happen at this point, so generously grant both access
1362 // and request permissions to the specific file to cover both cases.
1363 // We do not give it the permission to request all file:// URLs.
1364 policy->GrantRequestSpecificFileURL(renderer_id,
1365 net::FilePathToFileURL(filename.path));
1366
1367 // If the renderer already has permission to read these paths, we don't need
1368 // to re-grant them. This prevents problems with DnD for files in the CrOS
1369 // file manager--the file manager already had read/write access to those
1370 // directories, but dragging a file would cause the read/write access to be
1371 // overwritten with read-only access, making them impossible to delete or
1372 // rename until the renderer was killed.
1373 if (!policy->CanReadFile(renderer_id, filename.path))
1374 policy->GrantReadFile(renderer_id, filename.path);
1375 }
1376
1377 storage::IsolatedContext* isolated_context =
1378 storage::IsolatedContext::GetInstance();
1379 DCHECK(isolated_context);
1380
1381 if (!files.fileset().empty()) {
1382 std::string filesystem_id =
1383 isolated_context->RegisterDraggedFileSystem(files);
1384 if (!filesystem_id.empty()) {
1385 // Grant the permission iff the ID is valid.
1386 policy->GrantReadFileSystem(renderer_id, filesystem_id);
1387 }
1388 drop_data->filesystem_id = base::UTF8ToUTF16(filesystem_id);
1389 }
1390
1391 storage::FileSystemContext* file_system_context =
1392 BrowserContext::GetStoragePartition(GetProcess()->GetBrowserContext(),
1393 GetSiteInstance())
1394 ->GetFileSystemContext();
1395 for (auto& file_system_file : drop_data->file_system_files) {
1396 storage::FileSystemURL file_system_url =
1397 file_system_context->CrackURL(file_system_file.url);
1398
1399 std::string register_name;
1400 std::string filesystem_id = isolated_context->RegisterFileSystemForPath(
1401 file_system_url.type(), file_system_url.filesystem_id(),
1402 file_system_url.path(), &register_name);
1403
1404 if (!filesystem_id.empty()) {
1405 // Grant the permission iff the ID is valid.
1406 policy->GrantReadFileSystem(renderer_id, filesystem_id);
1407 }
1408
1409 // Note: We are using the origin URL provided by the sender here. It may be
1410 // different from the receiver's.
1411 file_system_file.url =
1412 GURL(storage::GetIsolatedFileSystemRootURIString(
1413 file_system_url.origin(), filesystem_id, std::string())
1414 .append(register_name));
1415 }
1416 }
1417
1357 } // namespace content 1418 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698