Add WebDragData to blink::WebView::dragtargetDrop

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 802 matching lines @@
       host->DragTargetDragEnter(drop_data, location, location, mask, 0);
       break;
     case blink::WebDragStatusOver:
       host->DragTargetDragOver(location, location, mask, 0);
       break;
     case blink::WebDragStatusLeave:
       embedder->DragLeftGuest(this);
       host->DragTargetDragLeave();
       break;
     case blink::WebDragStatusDrop:
-      host->DragTargetDrop(location, location, 0);
+      host->DragTargetDrop(DropData(), location, location, 0);

[lfg, 2016/03/07 21:07:10]

Sanity check, why shouldn't we pass drop_data here?

[hush (inactive), 2016/03/07 21:21:31]

We could, but we don't have to (waste of bytes in IPC?). The drop_data during
"WebDragStatusDrop" is not different from the drop_data in "WebDragStatusEnter".

So passing an invalid dropdata here will make sure we reuse the DropData in
blink::WebViewImpl::dragTargetDrop.
We only pass a valid drop data during dragTargetDrop on Android platform. 

[lfg, 2016/03/07 21:25:23]

lgtm

       if (dragged_url_.is_valid()) {
         delegate_->DidDropLink(dragged_url_);
         dragged_url_ = GURL();
       }
       break;
     case blink::WebDragStatusUnknown:
       NOTREACHED();
   }
   last_drag_status_ = drag_status;
   EndSystemDragIfApplicable();
@@ skipping 179 matching lines @@
           range, character_bounds);
 }
 #endif
 
 void BrowserPluginGuest::SetContextMenuPosition(const gfx::Point& position) {
   if (delegate_)
     delegate_->SetContextMenuPosition(position);
 }
 
 }  // namespace content