third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp - Issue 1723753002: Make Document::isSecureContext() work for OOPIFs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp

Issue 1723753002: Make Document::isSecureContext() work for OOPIFs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more rebase fixups Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp b/third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp

index 559b177490193f43e87f92681d85ff6521a65f49..b2f445689e6df04f99e8c52fec131061e20c3dd0 100644

--- a/third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp

@@ -123,13 +123,10 @@ bool WebSecurityOrigin::canRequest(const WebURL& url) const

return m_private->canRequest(url);

}

-bool WebSecurityOrigin::isPotentiallyTrustworthy(WebString& errorMessage) const

+bool WebSecurityOrigin::isPotentiallyTrustworthy() const

{

ASSERT(m_private);

- bool result = m_private->isPotentiallyTrustworthy();

- if (!result)

- errorMessage = WTF::String(m_private->isPotentiallyTrustworthyErrorMessage());

- return result;

+ return m_private->isPotentiallyTrustworthy();

}

WebString WebSecurityOrigin::toString() const