media/blink/webmediaplayer_util.cc - Issue 1723753002: Make Document::isSecureContext() work for OOPIFs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_util.cc

Issue 1723753002: Make Document::isSecureContext() work for OOPIFs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more rebase fixups Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/webmediaplayer_util.cc

diff --git a/media/blink/webmediaplayer_util.cc b/media/blink/webmediaplayer_util.cc

index 05342f0bbd25191a370e891cc526fc1743036761..5828e9c2c09eee7a98587db673a64e806544c1d7 100644

--- a/media/blink/webmediaplayer_util.cc

+++ b/media/blink/webmediaplayer_util.cc

@@ -132,8 +132,7 @@ void ReportMetrics(blink::WebMediaPlayer::LoadType load_type,

// For MSE, also report usage by secure/insecure origin.

if (load_type == blink::WebMediaPlayer::LoadTypeMediaSource) {

- blink::WebString error_message;

- if (security_origin.isPotentiallyTrustworthy(error_message)) {

+ if (security_origin.isPotentiallyTrustworthy()) {

GetMediaClient()->RecordRapporURL("Media.OriginUrl.MSE.Secure",

security_origin_url);

} else {