Make Document::isSecureContext() work for OOPIFs

third_party/WebKit/Source/core/dom/DocumentTest.cpp

 /*
  * Copyright (c) 2014, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #include "core/dom/Document.h"
 
 #include "core/dom/DocumentVisibilityObserver.h"
 #include "core/frame/FrameView.h"
 #include "core/html/HTMLHeadElement.h"
 #include "core/html/HTMLLinkElement.h"
 #include "core/testing/DummyPageHolder.h"
 #include "platform/heap/Handle.h"
 #include "platform/weborigin/ReferrerPolicy.h"
+#include "platform/weborigin/SchemeRegistry.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
 
 class DocumentTest : public ::testing::Test {
 protected:
     void SetUp() override;
 
@@ skipping 296 matching lines @@
     element->setAttribute(blink::HTMLNames::classAttr, "a");
     EXPECT_NE(previousStyleVersion, document().styleVersion());
 
     document().view()->updateAllLifecyclePhases();
 
     previousStyleVersion = document().styleVersion();
     element->setAttribute(blink::HTMLNames::classAttr, "a b");
     EXPECT_NE(previousStyleVersion, document().styleVersion());
 }
 
+TEST_F(DocumentTest, EnforceSandboxFlags)
+{
+    RefPtr<SecurityOrigin> origin = SecurityOrigin::createFromString("http://example.test");
+    document().setSecurityOrigin(origin);
+    SandboxFlags mask = SandboxNavigation;
+    document().enforceSandboxFlags(mask);
+    EXPECT_EQ(origin, document().securityOrigin());
+    EXPECT_FALSE(document().securityOrigin()->isPotentiallyTrustworthy());
+    EXPECT_FALSE(document().securityOrigin()->bypassSecureContextCheck());
+
+    mask |= SandboxOrigin;
+    document().enforceSandboxFlags(mask);
+    EXPECT_TRUE(document().securityOrigin()->isUnique());
+    EXPECT_FALSE(document().securityOrigin()->isPotentiallyTrustworthy());
+    EXPECT_FALSE(document().securityOrigin()->bypassSecureContextCheck());
+
+    SchemeRegistry::registerURLSchemeBypassingSecureContextCheck("special-scheme");
+    // A unique origin does not bypass secure context checks unless it is also potentially trustworthy.
+    origin = SecurityOrigin::createFromString("special-scheme://example.test");
+    document().setSecurityOrigin(origin);
+    document().enforceSandboxFlags(mask);
+    EXPECT_TRUE(document().securityOrigin()->isUnique());
+    EXPECT_FALSE(document().securityOrigin()->isPotentiallyTrustworthy());

[alexmos, 2016/03/09 18:45:06]

It seems this part of the test still might have been useful to verify that
putting a scheme on the bypass list won't make the origin potentially
trustworthy, no?

[estark, 2016/03/10 00:53:44]

Done.

+    EXPECT_FALSE(document().securityOrigin()->bypassSecureContextCheck());
+
+    SchemeRegistry::registerURLSchemeBypassingSecureContextCheck("very-special-scheme");
+    SchemeRegistry::registerURLSchemeAsSecure("very-special-scheme");
+    origin = SecurityOrigin::createFromString("very-special-scheme://example.test");
+    document().setSecurityOrigin(origin);
+    document().enforceSandboxFlags(mask);
+    EXPECT_TRUE(document().securityOrigin()->isUnique());
+    EXPECT_TRUE(document().securityOrigin()->isPotentiallyTrustworthy());
+    EXPECT_TRUE(document().securityOrigin()->bypassSecureContextCheck());
+
+    origin = SecurityOrigin::createFromString("https://example.test");
+    document().setSecurityOrigin(origin);
+    document().enforceSandboxFlags(mask);
+    EXPECT_TRUE(document().securityOrigin()->isUnique());
+    EXPECT_TRUE(document().securityOrigin()->isPotentiallyTrustworthy());
+    EXPECT_FALSE(document().securityOrigin()->bypassSecureContextCheck());
+}
+
 } // namespace blink