Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: runtime/vm/parser.cc

Issue 1723733002: Simplify various name flavors in VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/profiler_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index afa81fc053a37be8363fe96c489d89c5eeff972d..f5d8a8947d11f276ba17cf32ddbf5721f7988248 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -4605,7 +4605,7 @@ void Parser::ParseEnumDefinition(const Class& cls) {
SkipMetadata();
ExpectToken(Token::kENUM);
- const String& enum_name = String::Handle(Z, cls.PrettyName());
+ const String& enum_name = String::Handle(Z, cls.ScrubbedName());
ClassDesc enum_members(Z, cls, enum_name, false, cls.token_pos());
// Add instance field 'final int index'.
@@ -4703,7 +4703,7 @@ void Parser::ParseEnumDefinition(const Class& cls) {
// For the user-visible name of the enumeration value, we need to
// unmangle private names.
if (enum_ident->CharAt(0) == '_') {
- *enum_ident = String::IdentifierPrettyName(*enum_ident);
+ *enum_ident = String::ScrubName(*enum_ident);
}
enum_value_name = Symbols::FromConcat(name_prefix, *enum_ident);
enum_names.Add(enum_value_name, Heap::kOld);
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/profiler_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698