runtime/vm/class_finalizer.cc - Issue 1723733002: Simplify various name flavors in VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/class_finalizer.cc

Issue 1723733002: Simplify various name flavors in VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/class_finalizer.cc

diff --git a/runtime/vm/class_finalizer.cc b/runtime/vm/class_finalizer.cc

index 74304da0fc43ac6758dc81a3cfedbc06ceedf0fc..563682bae0683eeca10d5243cd1bb7ae38d22a91 100644

--- a/runtime/vm/class_finalizer.cc

+++ b/runtime/vm/class_finalizer.cc

@@ -2259,7 +2259,7 @@ void ClassFinalizer::ApplyMixinMembers(const Class& cls) {

script, func.token_pos(), Report::AtLocation,

Report::kError, Heap::kNew,

"constructor '%s' is illegal in mixin class %s",

- String::Handle(func.PrettyName()).ToCString(),

+ String::Handle(func.UserVisibleName()).ToCString(),

String::Handle(zone, mixin_cls.Name()).ToCString()));

ReportErrors(error, cls, cls.token_pos(),

« no previous file with comments | « runtime/vm/ast_printer.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »