third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp - Issue 1723723002: bluetooth: Implement Service.getCharacteristics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp

Issue 1723723002: bluetooth: Implement Service.getCharacteristics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Address jyasskin's comments and add moar tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp

index c540bdb4d4e9385232a6c0505daf52f7a81d5fb9..839ecc9b8ca6c196b41ed42801265e0eee7a6df9 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp

@@ -50,7 +50,8 @@ DOMException* BluetoothError::take(ScriptPromiseResolver*, const WebBluetoothErr

MAP_ERROR(ChooserCancelled, NotFoundError, "User cancelled the requestDevice() chooser.");

MAP_ERROR(ChooserDeniedPermission, NotFoundError, "User denied the browser permission to scan for Bluetooth devices.");

MAP_ERROR(ServiceNotFound, NotFoundError, "Service not found in device.");

- MAP_ERROR(CharacteristicNotFound, NotFoundError, "Characteristic not found in device.");

+ MAP_ERROR(CharacteristicNotFound, NotFoundError, "No Characteristics with specified UUID found in Service.");

+ MAP_ERROR(NoCharacteristicsFound, NotFoundError, "No Characteristics found in service.");

// NotSupportedErrors:

MAP_ERROR(GATTUnknownError, NotSupportedError, "GATT Error Unknown.");