Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blacklisted-characteristics-with-uuid.html

Issue 1723723002: bluetooth: Implement Service.getCharacteristics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin
Patch Set: Address jyasskin's comments and add moar tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blacklisted-characteristics-with-uuid.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/getCharacteristic-blacklist.html b/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blacklisted-characteristics-with-uuid.html
similarity index 52%
copy from third_party/WebKit/LayoutTests/bluetooth/getCharacteristic-blacklist.html
copy to third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blacklisted-characteristics-with-uuid.html
index c950fe583fb458080dc2ae4eb197184cac1368c4..5fd3a4dea7c94231809b24fb29a0e864f28f687c 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/getCharacteristic-blacklist.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blacklisted-characteristics-with-uuid.html
@@ -1,28 +1,22 @@
<!DOCTYPE html>
-<script src="../resources/testharness.js"></script>
-<script src="../resources/testharnessreport.js"></script>
-<script src="resources/bluetooth-helpers.js"></script>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script src="../resources/bluetooth-helpers.js"></script>
<script>
'use strict';
-
-test(t => { assert_true(window.testRunner instanceof Object); t.done(); },
- 'window.testRunner is required for the following tests.');
-
promise_test(() => {
testRunner.setBluetoothMockDataSet('HeartRateAndHIDAdapter');
- return requestDeviceWithKeyDown(
- {
- filters: [{services: ['device_information']}]
- })
+ return requestDeviceWithKeyDown({filters: [{services: ['device_information']}]})
.then(device => device.gatt.connect())
.then(gattServer => gattServer.getPrimaryService('device_information'))
.then(service => {
return assert_promise_rejects_with_message(
- service.getCharacteristic('serial_number_string'),
+ service.getCharacteristics('serial_number_string'),
new DOMException('getCharacteristic(s) called with blacklisted UUID. ' +
'https://goo.gl/4NeimX',
'SecurityError'),
'Serial Number String characteristic is blacklisted.');
});
-}, 'Serial Number String characteristic is blacklisted.');
+}, 'Serial Number String characteristic is blacklisted. Should reject with ' +
+ 'SecurityError.');
</script>

Powered by Google App Engine
This is Rietveld 408576698