Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

Issue 1723723002: bluetooth: Implement Service.getCharacteristics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin
Patch Set: Address jyasskin's comments and add moar tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
diff --git a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
index 3b7d328295bf479a507a899a4132bd09a8cff070..deb780df083e29b0ee05018cc1be1ffba26513c4 100644
--- a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
+++ b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
@@ -503,13 +503,19 @@ class LayoutTestBluetoothAdapterProvider {
// callback with [1] which corresponds to chest.
// - GetProperties: Returns
// BluetoothGattCharacteristic::PROPERTY_READ
+ // - Body Sensor Location (0x2a38)
+ // - Mock Functions:
+ // - Read: Calls GattCharacteristicValueChanged and success
+ // callback with [2] which corresponds to wrist.
+ // - GetProperties: Returns
+ // BluetoothGattCharacteristic::PROPERTY_READ
static scoped_ptr<testing::NiceMock<device::MockBluetoothGattService>>
GetHeartRateService(device::MockBluetoothAdapter* adapter,
device::MockBluetoothDevice* device);
// Characteristics
- // |BaseCharacteristic|(service, uuid)
+ // |BaseCharacteristic|(identifier, service, uuid)
// Descriptors added:
// None.
// Mock Functions:
@@ -519,7 +525,7 @@ class LayoutTestBluetoothAdapterProvider {
// Returns the descriptor matching the identifier provided if the
// descriptor was added to the characteristic.
// - GetIdentifier:
- // Returns: uuid + “ Identifier”
+ // Returns: identifier
// - GetUUID:
// Returns: uuid
// - IsLocal:
@@ -532,6 +538,7 @@ class LayoutTestBluetoothAdapterProvider {
// Returns: NULL
static scoped_ptr<testing::NiceMock<device::MockBluetoothGattCharacteristic>>
GetBaseGATTCharacteristic(
+ const std::string& identifier,
device::MockBluetoothGattService* service,
const std::string& uuid,
device::BluetoothGattCharacteristic::Properties properties);

Powered by Google App Engine
This is Rietveld 408576698