tools/metrics/histograms/histograms.xml - Issue 1723723002: bluetooth: Implement Service.getCharacteristics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1723723002: bluetooth: Implement Service.getCharacteristics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Clean up Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp ('K') | « third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothError.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index bce3cf4240b395184f3558969d262fe2d373322b..3f32ccb00db8e39ffd47b2fa63bfb0cbbc375bef 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -3538,6 +3538,30 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Bluetooth.Web.GetCharacteristics.Characteristic"

+ enum="GATTCharacteristicHash">

+ <owner>jyasskin@chromium.org</owner>

+ <owner>ortuno@chromium.org</owner>

+ <owner>scheib@chromium.org</owner>

+ <summary>

+ Records the UUIDs used when getting characteristics. The recorded value is a

+ 31-bit hash of the UUID. Used to know what types of characteristics to

+ target when building libraries that use the Web Bluetooth API.

+ </summary>

+</histogram>

+<histogram name="Bluetooth.Web.GetCharacteristics.Outcome"

+ enum="WebBluetoothGetCharacteristicOutcome">

+ <owner>jyasskin@chromium.org</owner>

+ <owner>ortuno@chromium.org</owner>

+ <owner>scheib@chromium.org</owner>

+ <summary>

+ Records the outcome of a call to getCharacteristics(). Used to understand

+ what errors developers are getting so we can target efforst toward the most

+ common ones.

+ </summary>

+</histogram>

<histogram name="Bluetooth.Web.GetPrimaryService.Outcome"

enum="WebBluetoothGetPrimaryServiceOutcome">

<owner>jyasskin@chromium.org</owner>

@@ -82502,6 +82526,7 @@ To add a new entry, add it with any value and run test to compute valid value.

+ <int value="9" label="Service.getCharacteristics()"/>

Jeffrey Yasskin 2016/02/24 23:20:30 Please update the label on "getCharacteristic()" t

ortuno 2016/02/25 23:08:27 Done.

</enum>