third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/characteristics-not-found-with-uuid.html - Issue 1723723002: bluetooth: Implement Service.getCharacteristics

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/characteristics-not-found-with-uuid.html

Issue 1723723002: bluetooth: Implement Service.getCharacteristics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Clean up Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/characteristics-not-found.html ('K') | « third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/characteristics-not-found.html ('k') | third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/device-goes-out-of-range.html » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script src="../resources/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7 promise_test(() => {

	8 testRunner.setBluetoothMockDataSet('HeartRateAdapter');

	9 let expected = new DOMException(

	10 'No Characteristics with specified UUID found in Service.',

	11 'NotFoundError');

	12 return requestDeviceWithKeyDown({filters: [{services: ['heart_rate']}]})

	13 .then(device => device.gatt.connect())

	14 .then(gattServer => gattServer.getPrimaryService('heart_rate'))

	15 .then(service => Promise.all(

	16 [assert_promise_rejects_with_message(

	17 service.getCharacteristics(battery_level.alias), expected),
	Jeffrey Yasskin 2016/02/24 23:20:29 I don't know that we need the alias/name/uuid trip I don't know that we need the alias/name/uuid triple for this test. ortuno 2016/02/25 23:08:27 Removed. But I added it to characteristic-found-wi Show quoted text On 2016/02/24 at 23:20:29, Jeffrey Yasskin wrote: > I don't know that we need the alias/name/uuid triple for this test. Removed. But I added it to characteristic-found-with-uuid.html otherwise we would never test if we actually support all three possibilities. Jeffrey Yasskin 2016/02/25 23:46:57 Yep, that looks like a better place. Show quoted text On 2016/02/25 23:08:27, ortuno wrote: > On 2016/02/24 at 23:20:29, Jeffrey Yasskin wrote: > > I don't know that we need the alias/name/uuid triple for this test. > > Removed. But I added it to characteristic-found-with-uuid.html otherwise we > would never test if we actually support all three possibilities. Yep, that looks like a better place.
	18 assert_promise_rejects_with_message(

	19 service.getCharacteristics(battery_level.name), expected),

	20 assert_promise_rejects_with_message(

	21 service.getCharacteristics(battery_level.uuid), expected)]));

	22 }, 'Request for absent characteristics with UUID. Reject with NotFoundError.');

	23 </script>

OLD	NEW