Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1723723002: bluetooth: Implement Service.getCharacteristics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin
Patch Set: Merge with ToT Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothRemoteGATTCharacteristicInit.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 5f5a88efeaa7fd7a86229b9a410eb6ed76241316..16eaef9e1d33fa4ae6415c71025b6da26dcd8069 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3551,7 +3551,31 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<owner>scheib@chromium.org</owner>
<summary>
Records the outcome of a call to getCharacteristic(). Used to understand
- what errors developers are getting so we can target efforst toward the most
+ what errors developers are getting so we can target efforts toward the most
+ common ones.
+ </summary>
+</histogram>
+
+<histogram name="Bluetooth.Web.GetCharacteristics.Characteristic"
+ enum="GATTCharacteristicHash">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Records the UUIDs used when getting characteristics. The recorded value is a
+ 31-bit hash of the UUID. Used to know what types of characteristics to
+ target when building libraries that use the Web Bluetooth API.
+ </summary>
+</histogram>
+
+<histogram name="Bluetooth.Web.GetCharacteristics.Outcome"
+ enum="WebBluetoothGetCharacteristicOutcome">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Records the outcome of a call to getCharacteristics(). Used to understand
+ what errors developers are getting so we can target efforts toward the most
common ones.
</summary>
</histogram>
@@ -82877,12 +82901,13 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="0" label="requestDevice()"/>
<int value="1" label="connectGATT()"/>
<int value="2" label="RemoteGATTServer.getPrimaryService()"/>
- <int value="3" label="getCharacteristic()"/>
+ <int value="3" label="Service.getCharacteristic()"/>
<int value="4" label="Characteristic.readValue()"/>
<int value="5" label="Characteristic.writeValue()"/>
<int value="6" label="Characteristic.startNotifications()"/>
<int value="7" label="Characteristic.stopNotifications()"/>
<int value="8" label="RemoteGATTServer.disconnect()"/>
+ <int value="9" label="Service.getCharacteristics()"/>
</enum>
<enum name="WebBluetoothGATTOperationOutcome" type="int">
@@ -82908,6 +82933,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="2" label="No service"/>
<int value="3" label="Not found"/>
<int value="4" label="Blacklisted"/>
+ <int value="5" label="No characteristics"/>
</enum>
<enum name="WebBluetoothGetPrimaryServiceOutcome" type="int">
« no previous file with comments | « third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothRemoteGATTCharacteristicInit.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698