Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: tools/dom/scripts/generator.py

Issue 1723703002: Fix generator to use SerializedScriptValue for all postMessages (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/generator.py
diff --git a/tools/dom/scripts/generator.py b/tools/dom/scripts/generator.py
index 5caca40bd46c4693714b729db8c547132560980a..a1ebfe29f6617515150723175d055d38d825c227 100644
--- a/tools/dom/scripts/generator.py
+++ b/tools/dom/scripts/generator.py
@@ -722,11 +722,12 @@ dart2js_conversions = monitored.Dict('generator.dart2js_conversions', {
'any set IDBCursor.update': _serialize_SSV,
# postMessage
+ 'SerializedScriptValue set': _serialize_SSV,
+ 'any set CompositorWorkerGlobalScope.postMessage': _serialize_SSV,
+ 'any set DedicatedWorkerGlobalScope.postMessage': _serialize_SSV,
'any set MessagePort.postMessage': _serialize_SSV,
- 'SerializedScriptValue set Window.postMessage': _serialize_SSV,
- 'SerializedScriptValue set Worker.postMessage': _serialize_SSV,
- 'any set DedicatedWorkerGlobalScope.postMessage' : _serialize_SSV,
- 'SerializedScriptValue set ServiceWorkerClient.postMessage': _serialize_SSV,
+ 'any set Window.postMessage': _serialize_SSV,
+ 'any set _DOMWindowCrossFrame.postMessage': _serialize_SSV,
terry 2016/02/23 14:19:04 I'm wondering how the tests ran on integration w/o
Alan Knight 2016/02/23 17:54:37 Good question. Maybe there's some interaction with
'* get CustomEvent.detail':
Conversion('convertNativeToDart_SerializedScriptValue',
@@ -1469,7 +1470,7 @@ def isList(return_type):
return return_type.startswith('List<') if return_type else False
def get_list_type(return_type):
- # Get the list type NNNN inside of List<NNNN>
+ # Get the list type NNNN inside of List<NNNN>
return return_type[5:-1] if isList(return_type) else return_type
def wrap_unwrap_list_blink(return_type, type_registry):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698