Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1723703002: Fix generator to use SerializedScriptValue for all postMessages (Closed)

Created:
4 years, 10 months ago by Alan Knight
Modified:
4 years, 10 months ago
Reviewers:
terry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix generator to use SerializedScriptValue for all postMessages BUG= Committed: https://github.com/dart-lang/sdk/commit/e67b4c916179aae334ab7458a857d39ac8867379

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M tools/dom/scripts/generator.py View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
terry
https://codereview.chromium.org/1723703002/diff/1/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/1723703002/diff/1/tools/dom/scripts/generator.py#newcode730 tools/dom/scripts/generator.py:730: 'any set _DOMWindowCrossFrame.postMessage': _serialize_SSV, I'm wondering how the tests ...
4 years, 10 months ago (2016-02-23 14:19:04 UTC) #2
Alan Knight
Committed patchset #2 (id:20001) manually as e67b4c916179aae334ab7458a857d39ac8867379 (presubmit successful).
4 years, 10 months ago (2016-02-23 17:29:00 UTC) #4
Alan Knight
4 years, 10 months ago (2016-02-23 17:54:37 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1723703002/diff/1/tools/dom/scripts/generator.py
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/1723703002/diff/1/tools/dom/scripts/generator...
tools/dom/scripts/generator.py:730: 'any set _DOMWindowCrossFrame.postMessage':
_serialize_SSV,
On 2016/02/23 14:19:04, terry wrote:
> I'm wondering how the tests ran on integration w/o any problems.

Good question. Maybe there's some interaction with something else that happened
on master in between?

> 
> Do we need to add postMessage for ServieWorkerClient?

I don't see that class. But this covers everything in dart:html, except that it
turns out for _DOMWindowCrossFrame it's from template and I need to fix that
one.

> There are some other like CrossOriginServiceWorker (I guess that's
> _DOMWindowCrossFrame)?

CrossOriginServiceWorkerClient gets generated correctly without the special case
here.

> 
> What about postMessage in CompositeWorkerGlobalScope?

I think you mean Compositor...  That's in there, it's the second one in the
list.

> 
> Noticed we never did this for ServiceWorker in 39/45 there is a postMessage
> shouldn't that have been there too?
> 
> There is a postMessage in ServicePort for 45 should that be here too?
> 
> And what about Worker it was in 39 and there's still a postMessage in 45?

As above, everything in dart:html should be good now.
> 
>

Powered by Google App Engine
This is Rietveld 408576698